Issue 7634031: Let pyauto create an attached webdriver instance to manipulate web pages.

Issue 7634031: Let pyauto create an attached webdriver instance to manipulate web pages. (Closed)

Created:
9 years, 4 months ago by kkania

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Paweł Hajdan Jr., Nirnimesh

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Let pyauto create an attached webdriver instance to manipulate web pages. Same patch as before with some fixes. BUG=49379 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96788

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : forgot to re-add the previously added files #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+361 lines, -156 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1	3 chunks	+28 lines, -0 lines	1 comment	Download
M	chrome/test/automation/automation_proxy_uitest.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/test/automation/proxy_launcher.h	View		3 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/test/automation/proxy_launcher.cc	View		3 chunks	+20 lines, -8 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
A	chrome/test/functional/pyauto_webdriver.py	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/test/pyautolib/chrome_driver_factory.py	View	1 2	1 chunk	+62 lines, -0 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View		4 chunks	+37 lines, -25 lines	0 comments	Download
A	chrome/test/pyautolib/pyauto_paths.py	View	1 2	1 chunk	+57 lines, -0 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/webdriver/automation.h	View	1	3 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/test/webdriver/automation.cc	View	1	3 chunks	+54 lines, -59 lines	0 comments	Download
M	chrome/test/webdriver/commands/create_session.cc	View	1	7 chunks	+22 lines, -21 lines	0 comments	Download
M	chrome/test/webdriver/session.h	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/test/webdriver/session.cc	View		3 chunks	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

9 years, 4 months ago (2011-08-15 17:33:21 UTC) #5

... and let me remind you about OWNERS of chrome/test

http://codereview.chromium.org/7634031/diff/11002/chrome/browser/automation/t...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/7634031/diff/11002/chrome/browser/automation/t...
chrome/browser/automation/testing_automation_provider.cc:6032:
provider->SetExpectedTabCount(0);
This duplicates code that initializes automation provider at browser startup.
Please don't do that, and share the code instead.

Expand Messages | Collapse Messages