chrome/test/webdriver/session.h - Issue 7634031: Let pyauto create an attached webdriver instance to manipulate web pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/session.h

Issue 7634031: Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: forgot to re-add the previously added files Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/testing_automation_provider.cc ('K') | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/webdriver/session.h

diff --git a/chrome/test/webdriver/session.h b/chrome/test/webdriver/session.h

index 881263d5b0db87b65bf2743ab5fe9278e9f8d283..b1018f27989af38291ec92e2f698ce6bf68f0712 100644

--- a/chrome/test/webdriver/session.h

+++ b/chrome/test/webdriver/session.h

@@ -79,9 +79,7 @@ class Session {

// It |user_data_dir| is empty, it will use a temporary dir.

// Returns true on success. On failure, the session will delete

// itself and return an error code.

- Error* Init(const FilePath& browser_exe,

- const FilePath& user_data_dir,

- const CommandLine& options);

+ Error* Init(const Automation::BrowserOptions& options);

// Should be called before executing a command. Performs necessary waits

// and frame switching.

@@ -329,9 +327,7 @@ class Session {

void RunSessionTaskOnSessionThread(

Task* task,

base::WaitableEvent* done_event);

- void InitOnSessionThread(const FilePath& browser_exe,

- const FilePath& user_data_dir,

- const CommandLine& options,

+ void InitOnSessionThread(const Automation::BrowserOptions& options,

Error** error);

void TerminateOnSessionThread();