Issue 7634018: base: Rename ValueType to something less redundant as _just_ Type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7634018: base: Rename ValueType to something less redundant as _just_ Type. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, joi+watch-content_chromium.org, Paweł Hajdan Jr., jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Rename ValueType to something less redundant as _just_ Type. So instead of: base::Value::ValueType We write a nice: base::Value::Type BUG=None TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96614

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -34 lines)			Patch
M	base/values.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	base/values.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/default_pref_store.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/default_pref_store.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/prefs/pref_model_associator_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_service.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/prefs/pref_service.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_store.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_store.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/scoped_user_pref_update.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prefs/scoped_user_pref_update.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/core_options_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/core_options_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/json_schema_validator_unittest_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/v8_value_converter_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 4 months ago (2011-08-12 17:55:47 UTC) #2

LGTM, thanks for simplifying it while cleaning up the base thing

Expand Messages | Collapse Messages