Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: base/values.h

Issue 7634018: base: Rename ValueType to something less redundant as _just_ Type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index e0dd954537af798bf8415deb69ab1acbaf940ec3..3af36c04d028c7fb754920dd12b7008c6c2222ba 100644
--- a/base/values.h
+++ b/base/values.h
@@ -54,7 +54,7 @@ typedef std::map<std::string, Value*> ValueMap;
// the subclasses.
class BASE_EXPORT Value {
public:
- enum ValueType {
+ enum Type {
TYPE_NULL = 0,
TYPE_BOOLEAN,
TYPE_INTEGER,
@@ -79,13 +79,13 @@ class BASE_EXPORT Value {
// Returns the type of the value stored by the current Value object.
// Each type will be implemented by only one subclass of Value, so it's
- // safe to use the ValueType to determine whether you can cast from
+ // safe to use the Type to determine whether you can cast from
// Value* to (Implementing Class)*. Also, a Value object never changes
// its type after construction.
- ValueType GetType() const { return type_; }
+ Type GetType() const { return type_; }
// Returns true if the current object represents a given type.
- bool IsType(ValueType type) const { return type == type_; }
+ bool IsType(Type type) const { return type == type_; }
// These methods allow the convenient retrieval of settings.
// If the current setting object can be converted into the given type,
@@ -116,12 +116,12 @@ class BASE_EXPORT Value {
protected:
// This isn't safe for end-users (they should use the Create*Value()
// static methods above), but it's useful for subclasses.
- explicit Value(ValueType type);
+ explicit Value(Type type);
private:
Value();
- ValueType type_;
+ Type type_;
DISALLOW_COPY_AND_ASSIGN(Value);
};
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698