Issue 7633034: Use Titlebar instead of TitleBar consistently in panels code.

Issue 7633034: Use Titlebar instead of TitleBar consistently in panels code. (Closed)

Created:
9 years, 4 months ago by prasadt

Modified:
9 years, 4 months ago

Reviewers:
jianli

CC:
chromium-reviews, jennb, Dmitry Titov, jianli, prasadt, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use Titlebar instead of TitleBar consistently in panels code. Suggestion from earlier code review feedback. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96802

Patch Set 2 : Code review feedback. #

Total comments: 2

Patch Set 3 : Code review feedback. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -69 lines)			Patch
M	chrome/browser/ui/panels/native_panel.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_frame_view.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_frame_view.cc	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.h	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.cc	View	1	8 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view_browsertest.cc	View	1 2	4 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_gtk.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_gtk.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_manager.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_mouse_watcher_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jianli

For more consistency, please also consider changing "title bar" to titlebar in the comments. http://codereview.chromium.org/7633034/diff/1/chrome/browser/ui/panels/native_panel.h ...

9 years, 4 months ago (2011-08-12 21:34:51 UTC) #2

prasadt

http://codereview.chromium.org/7633034/diff/1/chrome/browser/ui/panels/native_panel.h File chrome/browser/ui/panels/native_panel.h (right): http://codereview.chromium.org/7633034/diff/1/chrome/browser/ui/panels/native_panel.h#newcode57 chrome/browser/ui/panels/native_panel.h:57: virtual void UpdatePanelTitlebar() = 0; On 2011/08/12 21:34:51, jianli ...

9 years, 4 months ago (2011-08-12 21:59:30 UTC) #3

jianli

http://codereview.chromium.org/7633034/diff/7001/chrome/browser/ui/panels/panel_browser_view_browsertest.cc File chrome/browser/ui/panels/panel_browser_view_browsertest.cc (left): http://codereview.chromium.org/7633034/diff/7001/chrome/browser/ui/panels/panel_browser_view_browsertest.cc#oldcode384 chrome/browser/ui/panels/panel_browser_view_browsertest.cc:384: int title_bar_height = frame_view->NonClientTopBorderHeight() - One more thing to ...

9 years, 4 months ago (2011-08-12 22:14:43 UTC) #4

prasadt

9 years, 4 months ago (2011-08-12 22:30:52 UTC) #5

LGTM.

Expand Messages | Collapse Messages