Use Titlebar instead of TitleBar consistently in panels code.

chrome/browser/ui/panels/panel_browser_view_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/i18n/time_formatting.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 248 matching lines @@
                                                              SHOW_AS_ACTIVE);
     Panel* panel3 = browser_view3->panel_.get();
 
     // Test bringing up or down the title-bar of all minimized panels.
     EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
     panel3->SetExpansionState(Panel::MINIMIZED);
     EXPECT_EQ(Panel::MINIMIZED, panel3->expansion_state());
 
     PanelManager* panel_manager = PanelManager::GetInstance();
 
-    panel_manager->BringUpOrDownTitleBarForAllMinimizedPanels(true);
+    panel_manager->BringUpOrDownTitlebarForAllMinimizedPanels(true);
     EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
     EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
     EXPECT_EQ(Panel::TITLE_ONLY, panel3->expansion_state());
 
-    panel_manager->BringUpOrDownTitleBarForAllMinimizedPanels(false);
+    panel_manager->BringUpOrDownTitlebarForAllMinimizedPanels(false);
     EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
     EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
     EXPECT_EQ(Panel::MINIMIZED, panel3->expansion_state());
 
     // Test if it is OK to bring up title-bar given the mouse position.
-    EXPECT_TRUE(panel_manager->ShouldBringUpTitleBarForAllMinimizedPanels(
+    EXPECT_TRUE(panel_manager->ShouldBringUpTitlebarForAllMinimizedPanels(
         panel1->GetBounds().x(), panel1->GetBounds().y()));
-    EXPECT_FALSE(panel_manager->ShouldBringUpTitleBarForAllMinimizedPanels(
+    EXPECT_FALSE(panel_manager->ShouldBringUpTitlebarForAllMinimizedPanels(
         panel2->GetBounds().x(), panel2->GetBounds().y()));
-    EXPECT_TRUE(panel_manager->ShouldBringUpTitleBarForAllMinimizedPanels(
+    EXPECT_TRUE(panel_manager->ShouldBringUpTitlebarForAllMinimizedPanels(
         panel3->GetBounds().right() - 1, panel3->GetBounds().bottom() - 1));
-    EXPECT_TRUE(panel_manager->ShouldBringUpTitleBarForAllMinimizedPanels(
+    EXPECT_TRUE(panel_manager->ShouldBringUpTitlebarForAllMinimizedPanels(
         panel3->GetBounds().right() - 1, panel3->GetBounds().bottom() + 10));
-    EXPECT_FALSE(panel_manager->ShouldBringUpTitleBarForAllMinimizedPanels(
+    EXPECT_FALSE(panel_manager->ShouldBringUpTitlebarForAllMinimizedPanels(
         0, 0));
 
     panel1->Close();
     EXPECT_TRUE(IsMouseWatcherStarted());
     panel2->Close();
     EXPECT_TRUE(IsMouseWatcherStarted());
     panel3->Close();
     EXPECT_FALSE(IsMouseWatcherStarted());
   }
 
@@ skipping 32 matching lines @@
     EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
     browser_view->DrawAttention();
     EXPECT_TRUE(browser_view->IsDrawingAttention());
     EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
     MessageLoop::current()->RunAllPending();
     EXPECT_EQ(attention_color, frame_view->title_label_->GetColor());
 
     // Test that we cannot bring up other minimized panel if the mouse is over
     // the panel that draws attension.
     EXPECT_FALSE(PanelManager::GetInstance()->
-        ShouldBringUpTitleBarForAllMinimizedPanels(
+        ShouldBringUpTitlebarForAllMinimizedPanels(
             panel->GetBounds().x(), panel->GetBounds().y()));
 
     // Test that we cannot bring down the panel that is drawing the attention.
-    PanelManager::GetInstance()->BringUpOrDownTitleBarForAllMinimizedPanels(
+    PanelManager::GetInstance()->BringUpOrDownTitlebarForAllMinimizedPanels(
         false);
     EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
 
     // Test that the attention is cleared.
     browser_view->StopDrawingAttention();
     EXPECT_FALSE(browser_view->IsDrawingAttention());
     EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
     MessageLoop::current()->RunAllPending();
     EXPECT_NE(attention_color, frame_view->title_label_->GetColor());
 
@@ skipping 18 matching lines @@
   EXPECT_TRUE(frame_view->Contains(frame_view->title_label_));
   EXPECT_TRUE(frame_view->Contains(frame_view->settings_button_));
   EXPECT_TRUE(frame_view->Contains(frame_view->close_button_));
 
   // These controls should be visible.
   EXPECT_TRUE(frame_view->title_icon_->IsVisible());
   EXPECT_TRUE(frame_view->title_label_->IsVisible());
   EXPECT_TRUE(frame_view->close_button_->IsVisible());
 
   // Validate their layouts.
   int title_bar_height = frame_view->NonClientTopBorderHeight() -

[jianli, 2011/08/12 22:14:43]

One more thing to change for consistency: title_bar => titlebar

[prasadt, 2011/08/12 22:30:52]

Done.

       frame_view->NonClientBorderThickness();
   EXPECT_GT(frame_view->title_icon_->width(), 0);
   EXPECT_GT(frame_view->title_icon_->height(), 0);
   EXPECT_LT(frame_view->title_icon_->height(), title_bar_height);
   EXPECT_GT(frame_view->title_label_->width(), 0);
   EXPECT_GT(frame_view->title_label_->height(), 0);
   EXPECT_LT(frame_view->title_label_->height(), title_bar_height);
   EXPECT_GT(frame_view->settings_button_->width(), 0);
   EXPECT_GT(frame_view->settings_button_->height(), 0);
   EXPECT_LT(frame_view->settings_button_->height(), title_bar_height);
@@ skipping 66 matching lines @@
   target_bounds.set_height(target_bounds.height() + 50);
   browser_view->SetBounds(target_bounds);
   ASSERT_TRUE(browser_view->bounds_animator_.get());
   EXPECT_TRUE(browser_view->bounds_animator_->is_animating());
   EXPECT_NE(browser_view->GetBounds(), target_bounds);
   WaitTillBoundsAnimationFinished(browser_view);
   EXPECT_EQ(browser_view->GetBounds(), target_bounds);
 
   // Validates that no animation should be triggered for the panel currently
   // being dragged.
-  browser_view->OnTitleBarMousePressed(gfx::Point(
+  browser_view->OnTitlebarMousePressed(gfx::Point(
       target_bounds.x(), target_bounds.y()));
-  browser_view->OnTitleBarMouseDragged(gfx::Point(
+  browser_view->OnTitlebarMouseDragged(gfx::Point(
       target_bounds.x() + 5, target_bounds.y() + 5));
   EXPECT_FALSE(browser_view->bounds_animator_->is_animating());
-  browser_view->OnTitleBarMouseCaptureLost();
+  browser_view->OnTitlebarMouseCaptureLost();
 
   browser_view->panel()->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, CreateSettingsMenu) {
   TestCreateSettingsMenuForExtension(
       FILE_PATH_LITERAL("extension1"), Extension::EXTERNAL_POLICY_DOWNLOAD,
       "", "");
   TestCreateSettingsMenuForExtension(
       FILE_PATH_LITERAL("extension2"), Extension::INVALID,
       "http://home", "options.html");
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, MinimizeAndRestore) {
   TestMinimizeAndRestore();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, DrawAttention) {
   TestDrawAttention();
 }
 #endif