Added WebIntents GetAll support

Added WebIntents GetAll support

R=jhawkins@chromium.org
BUG=none
TEST=WebIntentsTableTest.GetAllIntents,WebDataServiceTest.WebIntents.GetAll,WebIntentsRegistryTest.GetAllIntents,


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96673

[Greg Billock, 2011-08-12 17:34:25]

http://codereview.chromium.org/7633011/diff/1/chrome/browser/intents/web_inte...
File chrome/browser/intents/web_intents_registry_unittest.cc (right):

http://codereview.chromium.org/7633011/diff/1/chrome/browser/intents/web_inte...
chrome/browser/intents/web_intents_registry_unittest.cc:116: 
Need another "RegisterIntentProvider" here?

http://codereview.chromium.org/7633011/diff/1/chrome/browser/intents/web_inte...
chrome/browser/intents/web_intents_registry_unittest.cc:120: EXPECT_EQ(2U,
consumer.intents_.size());
Looks like it should be ASSERT

http://codereview.chromium.org/7633011/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.cc (right):

http://codereview.chromium.org/7633011/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.cc:259: ScheduleTask(
Do these need to schedule on the DB thread or File thread? If we're already
there, why delegate?

[groby-ooo-7-16, 2011-08-12 19:51:38]

http://codereview.chromium.org/7633011/diff/1/chrome/browser/intents/web_inte...
File chrome/browser/intents/web_intents_registry_unittest.cc (right):

http://codereview.chromium.org/7633011/diff/1/chrome/browser/intents/web_inte...
chrome/browser/intents/web_intents_registry_unittest.cc:120: EXPECT_EQ(2U,
consumer.intents_.size());
On 2011/08/12 17:34:25, Greg Billock wrote:
> Looks like it should be ASSERT

Done.

http://codereview.chromium.org/7633011/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.cc (right):

http://codereview.chromium.org/7633011/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.cc:259: ScheduleTask(
On 2011/08/12 17:34:25, Greg Billock wrote:
> Do these need to schedule on the DB thread or File thread? If we're already
> there, why delegate?

They're scheduled on the DB thread - see
http://google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/webdata/web_data_...

You usually call the WebDataService from the UI thread, so that's one reason for
the scheduling.  I'd assume we always delegate to ensure WDS calls are
asynchronous - but you'd have to ask the owner of WDS.

I've modelled this after every other call on WDS :)

[James Hawkins, 2011-08-12 20:21:24]

LGTM with nits.

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_d...
File chrome/browser/webdata/web_data_service_unittest.cc (right):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_d...
chrome/browser/webdata/web_data_service_unittest.cc:661:
intent.action=ASCIIToUTF16("share");
Spaces around operators.

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
File chrome/browser/webdata/web_intents_table.cc (left):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
chrome/browser/webdata/web_intents_table.cc:87: 
Add this blank line back.

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
File chrome/browser/webdata/web_intents_table.cc (right):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
chrome/browser/webdata/web_intents_table.cc:75: "SELECT service_url, action,
type FROM web_intents "));
Remove trailing space in the string.

[groby-ooo-7-16, 2011-08-12 20:40:50]

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_d...
File chrome/browser/webdata/web_data_service_unittest.cc (right):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_d...
chrome/browser/webdata/web_data_service_unittest.cc:661:
intent.action=ASCIIToUTF16("share");
On 2011/08/12 20:21:24, James Hawkins wrote:
> Spaces around operators.

Done.

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
File chrome/browser/webdata/web_intents_table.cc (left):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
chrome/browser/webdata/web_intents_table.cc:87: 
On 2011/08/12 20:21:24, James Hawkins wrote:
> Add this blank line back.

Done.

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
File chrome/browser/webdata/web_intents_table.cc (right):

http://codereview.chromium.org/7633011/diff/5001/chrome/browser/webdata/web_i...
chrome/browser/webdata/web_intents_table.cc:75: "SELECT service_url, action,
type FROM web_intents "));
On 2011/08/12 20:21:24, James Hawkins wrote:
> Remove trailing space in the string.

Done.

[James Hawkins, 2011-08-12 20:44:40]

LGTM with nit.

http://codereview.chromium.org/7633011/diff/6010/chrome/browser/intents/web_i...
File chrome/browser/intents/web_intents_registry_unittest.cc (right):

http://codereview.chromium.org/7633011/diff/6010/chrome/browser/intents/web_i...
chrome/browser/intents/web_intents_registry_unittest.cc:107: WebIntentData
intent;
Indentation.

[commit-bot: I haz the power, 2011-08-13 03:48:46]

Change committed as 96673