Added WebIntents GetAll support

chrome/browser/webdata/web_data_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/web_data_service.h"
 
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/task.h"
 #include "base/threading/thread.h"
@@ skipping 232 matching lines @@
   GenericRequest<string16>* request = new GenericRequest<string16>(
       this, GetNextRequestHandle(), consumer, action);
   RegisterRequest(request);
   ScheduleTask(
       NewRunnableMethod(this,
                         &WebDataService::GetWebIntentsImpl,
                         request));
   return request->GetHandle();
 }
 
+WebDataService::Handle WebDataService::GetAllWebIntents(
+    WebDataServiceConsumer* consumer) {
+  DCHECK(consumer);
+  GenericRequest<std::string>* request = new GenericRequest<std::string>(
+      this, GetNextRequestHandle(), consumer, std::string());
+  RegisterRequest(request);
+  ScheduleTask(

[Greg Billock, 2011/08/12 17:34:25]

Do these need to schedule on the DB thread or File thread? If we're already
there, why delegate?

[groby-ooo-7-16, 2011/08/12 19:51:38]

They're scheduled on the DB thread - see
http://google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/webdata/web_data_...

You usually call the WebDataService from the UI thread, so that's one reason for
the scheduling.  I'd assume we always delegate to ensure WDS calls are
asynchronous - but you'd have to ask the owner of WDS.

I've modelled this after every other call on WDS :)

+      NewRunnableMethod(this,
+                        &WebDataService::GetAllWebIntentsImpl,
+                        request));
+  return request->GetHandle();
+}
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // Token Service
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 void WebDataService::SetTokenForService(const std::string& service,
                                         const std::string& token) {
   GenericRequest2<std::string, std::string>* request =
@@ skipping 591 matching lines @@
   InitializeDatabaseIfNecessary();
   if (db_ && !request->IsCancelled()) {
     std::vector<WebIntentData> result;
     db_->GetWebIntentsTable()->GetWebIntents(request->arg(), &result);
     request->SetResult(
         new WDResult<std::vector<WebIntentData> >(WEB_INTENTS_RESULT, result));
   }
   request->RequestComplete();
 }
 
+void WebDataService::GetAllWebIntentsImpl(
+    GenericRequest<std::string>* request) {
+  InitializeDatabaseIfNecessary();
+  if (db_ && !request->IsCancelled()) {
+    std::vector<WebIntentData> result;
+    db_->GetWebIntentsTable()->GetAllWebIntents(&result);
+    request->SetResult(
+        new WDResult<std::vector<WebIntentData> >(WEB_INTENTS_RESULT, result));
+  }
+  request->RequestComplete();
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 //
 // Token Service implementation.
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 // argument std::string is unused
 void WebDataService::RemoveAllTokensImpl(
     GenericRequest<std::string>* request) {
   InitializeDatabaseIfNecessary();
@@ skipping 535 matching lines @@
   return result_;
 }
 
 void WebDataService::WebDataRequest::RequestComplete() {
   WebDataService* s = service_;
   Task* t = NewRunnableMethod(s,
                               &WebDataService::RequestCompleted,
                               handle_);
   message_loop_->PostTask(FROM_HERE, t);
 }