Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 7633009: Use MessageLoopProxy for network message loop. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov
Modified:
9 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Use MessageLoopProxy for network message loop. When we switch to P2P Pepper API we will need to run networking code on the main plugin thread. Switching to MessageLoopProxy for network thread, so that it's easier to switch network thread in the future. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96651

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Total comments: 6

Patch Set 4 : - #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -184 lines) Patch
M remoting/client/chromoting_client.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/chromoting_client.cc View 10 chunks +10 lines, -11 lines 0 comments Download
M remoting/client/client_context.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M remoting/client/client_context.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_xmpp_proxy.h View 1 3 chunks +7 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_xmpp_proxy.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.cc View 10 chunks +13 lines, -11 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M remoting/host/client_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/host/heartbeat_sender.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/screen_recorder.h View 3 chunks +6 lines, -2 lines 0 comments Download
M remoting/host/screen_recorder.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/jingle_glue/jingle_thread.h View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M remoting/jingle_glue/jingle_thread.cc View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.h View 5 chunks +8 lines, -5 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.cc View 9 chunks +16 lines, -10 lines 0 comments Download
M remoting/protocol/client_control_sender.h View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/client_control_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_client.h View 3 chunks +6 lines, -3 lines 0 comments Download
M remoting/protocol/connection_to_client.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_host.h View 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/protocol/connection_to_host.cc View 10 chunks +15 lines, -13 lines 0 comments Download
M remoting/protocol/fake_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/host_control_sender.h View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/host_control_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/host_message_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/input_sender.h View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/input_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_session_manager.h View 3 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/protocol/message_reader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/message_reader.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M remoting/protocol/protobuf_video_writer.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/protocol/protobuf_video_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M remoting/protocol/protocol_test_client.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/rtcp_writer.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/protocol/rtcp_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/rtp_video_reader.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_reader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_reader_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_writer.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_writer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/rtp_video_writer_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/protocol/rtp_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/rtp_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/video_reader.h View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/video_reader.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M remoting/protocol/video_writer.h View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/protocol/video_writer.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
9 years, 4 months ago (2011-08-12 02:03:35 UTC) #1
Wez
If I understand this CL correctly, you're adding a |network_message_loop| parameter to the top-level connection ...
9 years, 4 months ago (2011-08-12 21:11:20 UTC) #2
Sergey Ulanov
On 2011/08/12 21:11:20, Wez wrote: > If I understand this CL correctly, you're adding a ...
9 years, 4 months ago (2011-08-12 21:24:00 UTC) #3
Sergey Ulanov
http://codereview.chromium.org/7633009/diff/4001/remoting/client/client_context.cc File remoting/client/client_context.cc (right): http://codereview.chromium.org/7633009/diff/4001/remoting/client/client_context.cc#newcode41 remoting/client/client_context.cc:41: &InitializeMessageLoopProxy, &network_message_loop_, &proxy_event)); On 2011/08/12 21:11:20, Wez wrote: > ...
9 years, 4 months ago (2011-08-12 21:24:17 UTC) #4
Wez
9 years, 4 months ago (2011-08-12 21:44:54 UTC) #5
LGTM with the message_loop_proxy() change.

Powered by Google App Engine
This is Rietveld 408576698