Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 7631012: Re-enable accidentally disabled DragPanels test on Windows. (Closed)

Created:
9 years, 4 months ago by prasadt
Modified:
9 years, 4 months ago
CC:
chromium-reviews, jennb, prasadt, jianli, Dmitry Titov, dcheng, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable accidentally disabled DragPanels test on Windows. modified: chrome/browser/ui/panels/panel_browsertest.cc BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97151

Patch Set 1 #

Patch Set 2 : Modify description #

Total comments: 2

Patch Set 3 : Switch to whitelist for enabling DragPanels test. #

Patch Set 4 : Removed comment about linux desktop. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
prasadt
9 years, 4 months ago (2011-08-16 22:48:50 UTC) #1
scherkus (not reviewing)
http://codereview.chromium.org/7631012/diff/1002/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (right): http://codereview.chromium.org/7631012/diff/1002/chrome/browser/ui/panels/panel_browsertest.cc#newcode308 chrome/browser/ui/panels/panel_browsertest.cc:308: (!defined(OS_WIN) && defined(TOOLKIT_VIEWS)) drive-by... I wonder if you could ...
9 years, 4 months ago (2011-08-16 23:29:12 UTC) #2
prasadt
http://codereview.chromium.org/7631012/diff/1002/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (right): http://codereview.chromium.org/7631012/diff/1002/chrome/browser/ui/panels/panel_browsertest.cc#newcode308 chrome/browser/ui/panels/panel_browsertest.cc:308: (!defined(OS_WIN) && defined(TOOLKIT_VIEWS)) On 2011/08/16 23:29:12, scherkus wrote: > ...
9 years, 4 months ago (2011-08-16 23:40:26 UTC) #3
prasadt
Removed comment about linux desktop as technically TOOLKIT_GTK is set for any platform that uses ...
9 years, 4 months ago (2011-08-16 23:47:24 UTC) #4
jennb
9 years, 4 months ago (2011-08-16 23:56:53 UTC) #5
LGTM

So much prettier!  Thanks.

Powered by Google App Engine
This is Rietveld 408576698