Re-enable accidentally disabled DragPanels test on Windows.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 286 matching lines @@
 #ifdef OS_MACOSX
 #define MAYBE_CreatePanelOnOverflow DISABLED_CreatePanelOnOverflow
 #else
 #define MAYBE_CreatePanelOnOverflow CreatePanelOnOverflow
 #endif
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MAYBE_CreatePanelOnOverflow) {
   TestCreatePanelOnOverflow();
 }
 
-#if defined(OS_MACOSX) || defined(OS_CHROMEOS) || defined(TOOLKIT_VIEWS)
+#if defined(OS_MACOSX) || defined(OS_CHROMEOS) || \
+    (!defined(OS_WIN) && defined(TOOLKIT_VIEWS))

[scherkus (not reviewing), 2011/08/16 23:29:12]

drive-by... I wonder if you could re-write this to have three sections:

#if win/gtk
// test is enabled
#else
// test is disabled
#endif


...in short have a whitelist of OSes that you know it passes as opposed to a
blacklist

[prasadt, 2011/08/16 23:40:26]

Jenn suggested that and I thought about that too before I sent this out.  I
didn't find a straightforward way to test for linux only that does not include
chromeos.  Uploaded a new cl that uses TOOLKIT_GTK for whitelisting linux.

 #define MAYBE_DragPanels DISABLED_DragPanels
 #else
 #define MAYBE_DragPanels DragPanels
 #endif
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MAYBE_DragPanels) {
   std::vector<Panel*> panels;
   panels.push_back(CreatePanel("PanelTest0", gfx::Rect()));
 
   int small_delta = 5;
@@ skipping 183 matching lines @@
   EXPECT_EQ(1, tabbed_browser->tab_count());
   ASSERT_TRUE(tabbed_browser->window()->IsDownloadShelfVisible());
   tabbed_browser->CloseWindow();
 #endif
 
   EXPECT_EQ(1, panel_browser->tab_count());
   ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());
 
   panel_browser->CloseWindow();
 }