Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/test/automation/proxy_launcher.h

Issue 7629019: Revert 96556 - Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/proxy_launcher.h
===================================================================
--- chrome/test/automation/proxy_launcher.h (revision 96579)
+++ chrome/test/automation/proxy_launcher.h (working copy)
@@ -65,10 +65,8 @@
virtual ~ProxyLauncher();
// Launches the browser if needed and establishes a connection with it.
- // Returns true on success.
- virtual bool InitializeConnection(
- const LaunchState& state,
- bool wait_for_initial_loads) WARN_UNUSED_RESULT = 0;
+ virtual void InitializeConnection(const LaunchState& state,
+ bool wait_for_initial_loads) = 0;
// Shuts down the browser if needed and destroys any
// connections established by InitalizeConnection.
@@ -290,9 +288,8 @@
bool launch_browser, bool disconnect_on_failure);
virtual AutomationProxy* CreateAutomationProxy(int execution_timeout);
- virtual bool InitializeConnection(
- const LaunchState& state,
- bool wait_for_initial_loads) OVERRIDE WARN_UNUSED_RESULT;
+ virtual void InitializeConnection(const LaunchState& state,
+ bool wait_for_initial_loads);
virtual void TerminateConnection();
virtual std::string PrefixedChannelID() const;
@@ -310,9 +307,8 @@
public:
explicit AnonymousProxyLauncher(bool disconnect_on_failure);
virtual AutomationProxy* CreateAutomationProxy(int execution_timeout);
- virtual bool InitializeConnection(
- const LaunchState& state,
- bool wait_for_initial_loads) OVERRIDE WARN_UNUSED_RESULT;
+ virtual void InitializeConnection(const LaunchState& state,
+ bool wait_for_initial_loads);
virtual void TerminateConnection();
virtual std::string PrefixedChannelID() const;
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698