Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5337)

Unified Diff: chrome/test/automation/automation_proxy_uitest.cc

Issue 7629019: Revert 96556 - Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/test/automation/proxy_launcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/automation_proxy_uitest.cc
===================================================================
--- chrome/test/automation/automation_proxy_uitest.cc (revision 96579)
+++ chrome/test/automation/automation_proxy_uitest.cc (working copy)
@@ -63,13 +63,9 @@
return *mock_;
}
- bool InitializeConnection(
- const LaunchState& state,
- bool wait_for_initial_loads) OVERRIDE WARN_UNUSED_RESULT {
- bool launch_browser_and_server =
- LaunchBrowserAndServer(state, wait_for_initial_loads);
- EXPECT_TRUE(launch_browser_and_server);
- return launch_browser_and_server;
+ void InitializeConnection(const LaunchState& state,
+ bool wait_for_initial_loads) {
+ ASSERT_TRUE(LaunchBrowserAndServer(state, wait_for_initial_loads));
}
void TerminateConnection() {
« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/test/automation/proxy_launcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698