Index: chrome/test/automation/proxy_launcher.cc |
=================================================================== |
--- chrome/test/automation/proxy_launcher.cc (revision 96579) |
+++ chrome/test/automation/proxy_launcher.cc (working copy) |
@@ -519,22 +519,17 @@ |
return proxy; |
} |
-bool NamedProxyLauncher::InitializeConnection(const LaunchState& state, |
+void NamedProxyLauncher::InitializeConnection(const LaunchState& state, |
bool wait_for_initial_loads) { |
if (launch_browser_) { |
#if defined(OS_POSIX) |
// Because we are waiting on the existence of the testing file below, |
// make sure there isn't one already there before browser launch. |
- if (!file_util::Delete(FilePath(channel_id_), false)) { |
- LOG(ERROR) << "Failed to delete " << channel_id_; |
- return false; |
- } |
+ EXPECT_TRUE(file_util::Delete(FilePath(channel_id_), false)); |
#endif |
- if (!LaunchBrowser(state)) { |
- LOG(ERROR) << "Failed to LaunchBrowser"; |
- return false; |
- } |
+ // Set up IPC testing interface as a client. |
+ ASSERT_TRUE(LaunchBrowser(state)); |
} |
// Wait for browser to be ready for connections. |
@@ -547,16 +542,9 @@ |
break; |
base::PlatformThread::Sleep(automation::kSleepTime); |
} |
- if (!channel_initialized) { |
- LOG(ERROR) << "Failed to wait for testing channel presence."; |
- return false; |
- } |
+ EXPECT_TRUE(channel_initialized); |
- if (!ConnectToRunningBrowser(wait_for_initial_loads)) { |
- LOG(ERROR) << "Failed to ConnectToRunningBrowser"; |
- return false; |
- } |
- return true; |
+ ASSERT_TRUE(ConnectToRunningBrowser(wait_for_initial_loads)); |
} |
void NamedProxyLauncher::TerminateConnection() { |
@@ -587,9 +575,9 @@ |
return proxy; |
} |
-bool AnonymousProxyLauncher::InitializeConnection(const LaunchState& state, |
+void AnonymousProxyLauncher::InitializeConnection(const LaunchState& state, |
bool wait_for_initial_loads) { |
- return LaunchBrowserAndServer(state, wait_for_initial_loads); |
+ ASSERT_TRUE(LaunchBrowserAndServer(state, wait_for_initial_loads)); |
} |
void AnonymousProxyLauncher::TerminateConnection() { |