Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7628006: GTTF: Use a fresh TestingBrowserProcess for each test, part #6 (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 4 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

GTTF: Use a fresh TestingBrowserProcess for each test, part #6 For a detailed description see part #1, http://codereview.chromium.org/6478005/ This CL fixes the bug fully on Linux. More platforms will follow. BUG=61062 TEST=unit_tests, possibly more Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96638

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : chromeos #

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/google_authenticator_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/online_attempt_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ownership_service_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_helper_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_temp_storage_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/desktop_notifications_unittest.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_policy_cache_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
9 years, 4 months ago (2011-08-11 22:10:33 UTC) #1
Jay Civelli
9 years, 4 months ago (2011-08-12 00:01:57 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698