Issue 7623002: Build fix in for linux_use_heapchecker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7623002: Build fix in for linux_use_heapchecker (Closed)

Created:
9 years, 4 months ago by kinuko

Modified:
9 years, 4 months ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Build fix for linux_use_heapchecker Make sure we return value in non-void function. BUG=none TBR=erikwright TEST=it builds with linux_use_heapchecker=1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96343

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/plugins/ppapi/quota_file_io.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

9 years, 4 months ago (2011-08-11 14:24:00 UTC) #2

http://codereview.chromium.org/7623002/diff/1/webkit/plugins/ppapi/quota_file...
File webkit/plugins/ppapi/quota_file_io.cc (right):

http://codereview.chromium.org/7623002/diff/1/webkit/plugins/ppapi/quota_file...
webkit/plugins/ppapi/quota_file_io.cc:29: NOTREACHED();
I wonder if removing the NOTREACHED would also work. If so, I think that would
be reasonable since (1) we can apparently rely on the compiler to tell us if
there is a non-returning path and (2) having a 'default' case is as literate as
the NOTREACHED.

Otherwise, I would probably remove the default case and the NOTREACHED and have
the final return be actually used.

Expand Messages | Collapse Messages