Build fix in for linux_use_heapchecker

webkit/plugins/ppapi/quota_file_io.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/quota_file_io.h"
 
 #include "base/stl_util.h"
 #include "base/message_loop_proxy.h"
 #include "base/task.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 using base::PlatformFile;
 using base::PlatformFileError;
 using quota::StorageType;
 
 namespace webkit {
 namespace ppapi {
 
 namespace {
 StorageType PPFileSystemTypeToQuotaStorageType(PP_FileSystemType type) {
   switch (type) {
     case PP_FILESYSTEMTYPE_LOCALPERSISTENT:
       return quota::kStorageTypePersistent;
     case PP_FILESYSTEMTYPE_LOCALTEMPORARY:
       return quota::kStorageTypeTemporary;
     default:
       return quota::kStorageTypeUnknown;
   }
   NOTREACHED();

[erikwright (departed), 2011/08/11 14:24:00]

I wonder if removing the NOTREACHED would also work. If so, I think that would
be reasonable since (1) we can apparently rely on the compiler to tell us if
there is a non-returning path and (2) having a 'default' case is as literate as
the NOTREACHED.

Otherwise, I would probably remove the default case and the NOTREACHED and have
the final return be actually used.

+  return quota::kStorageTypeUnknown;
 }
 }  // namespace
 
 class QuotaFileIO::PendingOperationBase {
  public:
   virtual ~PendingOperationBase() {}
 
   // Either one of Run() or DidFail() is called (the latter is called when
   // there was more than one error during quota queries).
   virtual void Run() = 0;
@@ skipping 312 matching lines @@
   pending_callbacks_.pop_front();
   DCHECK(pending_callbacks_.empty());
   int64_t delta = (error != base::PLATFORM_FILE_OK) ? 0 :
       new_file_size - cached_file_size_;
   instance_->delegate()->DidUpdateFile(file_url_, delta);
   inflight_operations_ = 0;
 }
 
 }  // namespace ppapi
 }  // namespace webkit