Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 7623001: Rename and document glCommandBufferEnableCHROMIUM (Closed)

Created:
9 years, 4 months ago by greggman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Erik does not do reviews, jam, mihaip+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Rename and document glCommandBufferEnableCHROMIUM moved to gl2ext.h. Got rid of gles2_command_buffer.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96507

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -110 lines) Patch
M content/renderer/gpu/renderer_gl_context.cc View 2 chunks +1 line, -3 lines 0 comments Download
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_enable_feature.txt View 1 chunk +67 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2ext.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
D gpu/GLES2/gles2_command_buffer.h View 1 chunk +0 lines, -38 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 2 chunks +13 lines, -13 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_id_test_autogen.h View 1 2 3 4 2 chunks +24 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Al, could you review this. It's not as bad as it looks. Just lots of ...
9 years, 4 months ago (2011-08-11 11:13:17 UTC) #1
greggman
Ken, could you review webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc Basically I have to remove the ability of pepper to ...
9 years, 4 months ago (2011-08-11 11:14:14 UTC) #2
apatrick_chromium
LGTM
9 years, 4 months ago (2011-08-11 18:00:12 UTC) #3
Ken Russell (switch to Gerrit)
webgraphicscontext3d_in_process_command_buffer_impl.cc LGTM Was no update needed to src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc?
9 years, 4 months ago (2011-08-11 22:57:37 UTC) #4
greggman
On 2011/08/11 22:57:37, kbr wrote: > webgraphicscontext3d_in_process_command_buffer_impl.cc LGTM > > Was no update needed to ...
9 years, 4 months ago (2011-08-12 03:09:48 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 03:10:49 UTC) #6
Presubmit check for 7623001-89 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  gpu/command_buffer/build_gles2_cmd_buffer.py, line 211, 82 chars

License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  gpu/GLES2/gl2ext.h

Presubmit checks took 2.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698