Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7621076: Add a sample webRequest extension. (Closed)

Created:
9 years, 4 months ago by Matt Perry
Modified:
9 years, 4 months ago
Reviewers:
Boris Smus
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add a sample webRequest extension. BUG=62703 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97737

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : doctype #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
A chrome/common/extensions/docs/examples/extensions/catblock.zip View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/extensions/catblock/background.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/catblock/loldogs.js View 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/catblock/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
9 years, 4 months ago (2011-08-18 20:36:10 UTC) #1
Boris Smus
http://codereview.chromium.org/7621076/diff/2001/chrome/common/extensions/docs/examples/extensions/catblock/background.html File chrome/common/extensions/docs/examples/extensions/catblock/background.html (right): http://codereview.chromium.org/7621076/diff/2001/chrome/common/extensions/docs/examples/extensions/catblock/background.html#newcode23 chrome/common/extensions/docs/examples/extensions/catblock/background.html:23: </script> Since this is a public sample, can we ...
9 years, 4 months ago (2011-08-19 19:12:35 UTC) #2
Matt Perry
http://codereview.chromium.org/7621076/diff/2001/chrome/common/extensions/docs/examples/extensions/catblock/background.html File chrome/common/extensions/docs/examples/extensions/catblock/background.html (right): http://codereview.chromium.org/7621076/diff/2001/chrome/common/extensions/docs/examples/extensions/catblock/background.html#newcode23 chrome/common/extensions/docs/examples/extensions/catblock/background.html:23: </script> On 2011/08/19 19:12:35, Boris Smus wrote: > Since ...
9 years, 4 months ago (2011-08-19 20:04:51 UTC) #3
Boris Smus
On 2011/08/19 20:04:51, Matt Perry wrote: > http://codereview.chromium.org/7621076/diff/2001/chrome/common/extensions/docs/examples/extensions/catblock/background.html > File chrome/common/extensions/docs/examples/extensions/catblock/background.html > (right): > > ...
9 years, 4 months ago (2011-08-19 23:22:23 UTC) #4
Boris Smus
9 years, 4 months ago (2011-08-19 23:23:07 UTC) #5 
Other than the background page validation nit, LGTM

Powered by Google App Engine
This is Rietveld 408576698