chrome/common/extensions/docs/examples/extensions/catblock/background.html - Issue 7621076: Add a sample webRequest extension.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/examples/extensions/catblock/background.html

Issue 7621076: Add a sample webRequest extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="loldogs.js"></script>

	2 <script>

	3 // Simple extension to replace lolcat images from

	4 // http://icanhascheezburger.com/ with loldog images instead.

	5

	6 chrome.experimental.webRequest.onBeforeRequest.addListener(

	7 function(info) {

	8 console.log("Cat intercepted: " + info.url);

	9 // Redirect the lolcal request to a random loldog URL.

	10 var i = Math.round(Math.random() * loldogs.length);

	11 return {redirectUrl: loldogs[i]};

	12 },

	13 // filters

	14 {

	15 urls: [

	16 "http://icanhascheezburger.files.wordpress.com/*",

	17 "http://chzmemebase.files.wordpress.com/*",

	18 ],

	19 types: ["image"]

	20 },

	21 // extraInfoSpec

	22 ["blocking"]);

	23 </script>
	Boris Smus 2011/08/19 19:12:35 Since this is a public sample, can we make this pa Since this is a public sample, can we make this page validate? Like with <!doctype html> and all that good stuff. At least so it passes http://html5.validator.nu/ Matt Perry 2011/08/19 20:04:51 I don't think we should try to assert that backgro Show quoted text On 2011/08/19 19:12:35, Boris Smus wrote: > Since this is a public sample, can we make this page validate? Like with > <!doctype html> and all that good stuff. At least so it passes > http://html5.validator.nu/ I don't think we should try to assert that background pages need to be perfectly valid HTML. They're not visible documents, so they'll only really contain script tags. Many of the other samples follow this pattern as well.
OLD	NEW