Unify gyp rules for running protoc.

Unify gyp rules for running protoc.

- Add a protoc.gypi that can be gyp-included into any gyp file that
  wants to build .proto files.
- Convert two remoting gyp files to use this new protoc.gypi.

(Also fixes a bug in one of those remoting gyp files; a mistaken path
was causing it to always rebuild under Xcode.)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97366

[Evan Martin, 2011-08-18 20:11:16]

This is based on TVL's grit stuff.

mark/tvl: review
hclam: FYI

If this works, I can convert the rest of the tree to using it.

[Evan Martin, 2011-08-18 20:12:20]

(n.b.: the weird output paths, like foo_pb2.py, are just matching the existing
behavior; I don't know if we actually use these python files)

[TVL, 2011-08-18 20:22:39]

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi#newcode34
build/protoc.gypi:34: 'type': 'static_library',
should this be a default (type?) so the target can be what ever is needed?

[Evan Martin, 2011-08-18 20:24:48]

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi#newcode34
build/protoc.gypi:34: 'type': 'static_library',
On 2011/08/18 20:22:40, TVL wrote:
> should this be a default (type?) so the target can be what ever is needed?

I considered it, but I figure I can generalize this once I find a user that
requires it.  I see lots of 'type:none' bits in the tree, but they are all only
used in cases where someone didn't understand gyp.

[TVL, 2011-08-18 20:30:13]

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi#newcode34
build/protoc.gypi:34: 'type': 'static_library',
On 2011/08/18 20:24:49, Evan Martin wrote:
> On 2011/08/18 20:22:40, TVL wrote:
> > should this be a default (type?) so the target can be what ever is needed?
> 
> I considered it, but I figure I can generalize this once I find a user that
> requires it.  I see lots of 'type:none' bits in the tree, but they are all
only
> used in cases where someone didn't understand gyp.

Ok, approach makes sense to me.  Mark -

Maybe go ahead and extend this to more places to confirm there aren't other
hiccups?

ps-from a build pov, it would be better to directly use this in the targets that
want to us the protocol buffers rather then have it be another xcode/vsstudio
target that has to exist.

[Mark Mentovai, 2011-08-18 20:31:02]

thomasvl@chromium.org wrote:
> Ok, approach makes sense to me.  Mark -

What can I do for you?

[Mark Mentovai, 2011-08-18 20:32:27]

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi#newcode34
build/protoc.gypi:34: 'type': 'static_library',
This shouldn’t set type at all!

[TVL, 2011-08-18 20:33:30]

On Thu, Aug 18, 2011 at 4:30 PM, Mark Mentovai <mark@chromium.org> wrote:

> thomasvl@chromium.org wrote:
> > Ok, approach makes sense to me.  Mark -
>
> What can I do for you?
>

Sorry, was gonna say "Mark - thoughts?" and then started deleting to end up
with "Mark?" but never finished that process... :(

[Evan Martin, 2011-08-18 20:51:49]

I tried converting libphonenumber and found I needed an extra argument.  PTAL.

My intent is that as I convert subsequent files to use this, I will complexify
this as needed, but that it will be easier to review as incremental changes atop
this working base.

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/5/build/protoc.gypi#newcode34
build/protoc.gypi:34: 'type': 'static_library',
On 2011/08/18 20:32:27, Mark Mentovai wrote:
> This shouldn’t set type at all!

Done.

[Evan Martin, 2011-08-18 20:53:30]

If you're curious about the protoc restriction that required adding
proto_in_dir, observe this error message:

FAILED: cd remoting/proto; "../../out/Debug/protoc" "--proto_path=."
"../../remoting/proto/trace.proto"
"--cpp_out=../../out/Debug/gen/protoc_out/remoting/proto"
"--python_out=../../out/Debug/pyproto/remoting/proto"
../../remoting/proto/trace.proto: File does not reside within any path specified
using --proto_path (or -I).  You must specify a --proto_path which encompasses
this file.  Note that the proto_path must be an exact prefix of the .proto file
names -- protoc is too dumb to figure out when two paths (e.g. absolute and
relative) are equivalent (it's harder than you think).

[TVL, 2011-08-18 20:56:50]

lgtm

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi#newcode43
build/protoc.gypi:43: 'py_dir': '<(PRODUCT_DIR)/pyproto/<(proto_out_dir)',
'proto_in_dir?': '.'

if it's common?

[Wez, 2011-08-18 21:00:10]

LGTM on behalf of remoting, assuming things still build. :)

[Evan Martin, 2011-08-18 21:12:42]

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi#newcode43
build/protoc.gypi:43: 'py_dir': '<(PRODUCT_DIR)/pyproto/<(proto_out_dir)',
On 2011/08/18 20:56:50, TVL wrote:
> 'proto_in_dir?': '.'
> 
> if it's common?

Did you mean %?  The only use of '?' I could find was this:
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/testing/gtest.gyp&exa...

Seems to work, PTAL

[Alpha Left Google, 2011-08-19 10:53:46]

On 2011/08/18 21:12:42, Evan Martin wrote:
> http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi
> File build/protoc.gypi (right):
> 
> http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi#newcode43
> build/protoc.gypi:43: 'py_dir': '<(PRODUCT_DIR)/pyproto/<(proto_out_dir)',
> On 2011/08/18 20:56:50, TVL wrote:
> > 'proto_in_dir?': '.'
> > 
> > if it's common?
> 
> Did you mean %?  The only use of '?' I could find was this:
>
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/testing/gtest.gyp&exa...
> 
> Seems to work, PTAL

LGTM.

[TVL, 2011-08-19 13:18:27]

lgtm

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi
File build/protoc.gypi (right):

http://codereview.chromium.org/7621073/diff/4002/build/protoc.gypi#newcode43
build/protoc.gypi:43: 'py_dir': '<(PRODUCT_DIR)/pyproto/<(proto_out_dir)',
On 2011/08/18 21:12:43, Evan Martin wrote:
> On 2011/08/18 20:56:50, TVL wrote:
> > 'proto_in_dir?': '.'
> > 
> > if it's common?
> 
> Did you mean %?  The only use of '?' I could find was this:
>
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/testing/gtest.gyp&exa...
> 
> Seems to work, PTAL

Yes, sorry.