Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 7621031: Revert 97049 - Trying to see if it fixes sync_integration_tests (Closed)

Created:
9 years, 4 months ago by rvargas (doing something else)
Modified:
9 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, estade+watch_chromium.org, rginda+watch_chromium.org, achuith+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 97049 - Trying to see if it fixes sync_integration_tests [Mac] Flip the flag for multi-profiles to on by default. This also changes ProfileManager::GetProfileInfoCache() to be GetProfileInfo() and returning the ProfileInfoInterface, making it easier to mock out for testing. In the few places that require the full ProfileInfoCache, GetMutableProfileInfo() was added. Because a handful of Mac unittests make calls into g_browser_process for the ProfileManager, BrowserTestHelper was expanded to set that up with a TestingProfile and a FakeProfileInfo so that tests continue to pass. BUG=60105 TEST=Multi-profiles is on by default. Review URL: http://codereview.chromium.org/7648037 TBR=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -178 lines) Patch
M chrome/browser/profiles/fake_profile_info_interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/profile_menu_model.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/base/testing_profile_manager.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/test/base/testing_profile_manager.cc View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
9 years, 4 months ago (2011-08-17 01:17:20 UTC) #1
rvargas (doing something else)
9 years, 4 months ago (2011-08-17 02:21:53 UTC) #2
On 2011/08/17 01:17:20, rvargas wrote:

Looks like this was it.

See
http://build.chromium.org/p/chromium/builders/Mac10.6%20Sync/builds/8647/step...

multiple crashes.

Powered by Google App Engine
This is Rietveld 408576698