Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 7648037: [Mac] Flip the flag for multi-profiles to on by default. (Closed)

Created:
9 years, 4 months ago by Robert Sesek
Modified:
9 years, 3 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org
Visibility:
Public.

Description

[Mac] Flip the flag for multi-profiles to on by default. This also changes ProfileManager::GetProfileInfoCache() to be GetProfileInfo() and returning the ProfileInfoInterface, making it easier to mock out for testing. In the few places that require the full ProfileInfoCache, GetMutableProfileInfo() was added. Because a handful of Mac unittests make calls into g_browser_process for the ProfileManager, BrowserTestHelper was expanded to set that up with a TestingProfile and a FakeProfileInfo so that tests continue to pass. BUG=60105 TEST=Multi-profiles is on by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97049

Patch Set 1 #

Patch Set 2 : Explooooode the CL in scope #

Patch Set 3 : Un-needed includes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -35 lines) Patch
M chrome/browser/profiles/fake_profile_info_interface.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/profile_menu_model.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/base/testing_profile_manager.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/test/base/testing_profile_manager.cc View 1 2 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
For after http://codereview.chromium.org/7647002/ lands.
9 years, 4 months ago (2011-08-15 21:08:11 UTC) #1
sail
LGTM
9 years, 4 months ago (2011-08-15 21:11:40 UTC) #2
Robert Sesek
sail: PTAL mirandac: Changes done as we've discussed +mark: BrowserTestHelper. You reviewed changes to it ...
9 years, 4 months ago (2011-08-16 16:53:10 UTC) #3
Mark Mentovai
LGTM. I only reviewed browser_test_helper.{cc,h} as requested.
9 years, 4 months ago (2011-08-16 18:08:42 UTC) #4
Miranda Callahan
On 2011/08/16 18:08:42, Mark Mentovai wrote: > LGTM. I only reviewed browser_test_helper.{cc,h} as requested. LGTM!
9 years, 4 months ago (2011-08-16 19:18:31 UTC) #5
sail
9 years, 4 months ago (2011-08-16 20:17:33 UTC) #6
LGTM!

http://codereview.chromium.org/7648037/diff/6001/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc (right):

http://codereview.chromium.org/7648037/diff/6001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc:145:
g_browser_process->profile_manager()->GetMutableProfileInfo();
This doesn't have to be mutable if we move more of the ProfileInfoCache
interface to the parent class. We can do this later though.

Powered by Google App Engine
This is Rietveld 408576698