Issue 7619: - Removed a few indirections by making the two SemiSpaces...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7619: - Removed a few indirections by making the two SemiSpaces... (Closed)

Created:
12 years, 2 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Removed a few indirections by making the two SemiSpaces part of NewSpace and made NewSpace statically allocated. - Eliminated indirection in MigrateObject. Committed: http://code.google.com/p/v8/source/detail?r=517

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -187 lines)			Patch
M	src/globals.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/heap.cc	View	27 chunks	+50 lines, -69 lines	1 comment	Download
M	src/heap-inl.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	src/spaces.h	View	6 chunks	+25 lines, -38 lines	1 comment	Download
M	src/spaces.cc	View	10 chunks	+41 lines, -51 lines	1 comment	Download
M	src/spaces-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-spaces.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

12 years, 2 months ago (2008-10-17 09:02:41 UTC) #2

LGTM except for trivial comments below.  It's cute to solve a problem by
*removing* a level of indirection.  That's almost unheard of!

http://codereview.chromium.org/7619/diff/1/4
File src/heap.cc (right):

http://codereview.chromium.org/7619/diff/1/4#newcode2325
Line 2325: for(uint32_t bitmask = 1; bitmask != 0; bitmask = bitmask << 1) {
Need a space after 'for'.

http://codereview.chromium.org/7619/diff/1/7
File src/spaces.cc (right):

http://codereview.chromium.org/7619/diff/1/7#newcode765
Line 765: // Create a new space with a given allocation capacity (ie, the
capacity of
The comment is confusing because the capacity is not 'given' but found in a
static heap variable.

http://codereview.chromium.org/7619/diff/1/6
File src/spaces.h (right):

http://codereview.chromium.org/7619/diff/1/6#newcode882
Line 882: SemiSpace() :Space(NEW_SPACE, NOT_EXECUTABLE) {
A space (character) before 'Space'?

Expand Messages | Collapse Messages