- Removed a few indirections by making the two SemiSpaces...

test/cctest/test-spaces.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 139 matching lines @@
   CHECK(!invalid_page->is_valid());
 
   MemoryAllocator::TearDown();
 }
 
 
 TEST(NewSpace) {
   CHECK(Heap::ConfigureHeapDefault());
   CHECK(MemoryAllocator::Setup(Heap::MaxCapacity()));
 
-  NewSpace* s = new NewSpace(Heap::InitialSemiSpaceSize(),
-                             Heap::SemiSpaceSize(),
-                             NEW_SPACE);
-  CHECK(s != NULL);
+  NewSpace new_space;
 
   void* chunk =
       MemoryAllocator::ReserveInitialChunk(2 * Heap::YoungGenerationSize());
   CHECK(chunk != NULL);
   Address start = RoundUp(static_cast<Address>(chunk),
                           Heap::YoungGenerationSize());
-  CHECK(s->Setup(start, Heap::YoungGenerationSize()));
-  CHECK(s->HasBeenSetup());
+  CHECK(new_space.Setup(start, Heap::YoungGenerationSize()));
+  CHECK(new_space.HasBeenSetup());
 
-  while (s->Available() >= Page::kMaxHeapObjectSize) {
-    Object* obj = s->AllocateRaw(Page::kMaxHeapObjectSize);
+  while (new_space.Available() >= Page::kMaxHeapObjectSize) {
+    Object* obj = new_space.AllocateRaw(Page::kMaxHeapObjectSize);
     CHECK(!obj->IsFailure());
-    CHECK(s->Contains(HeapObject::cast(obj)));
+    CHECK(new_space.Contains(HeapObject::cast(obj)));
   }
 
-  s->TearDown();
-  delete s;
+  new_space.TearDown();
   MemoryAllocator::TearDown();
 }
 
 
 TEST(OldSpace) {
   CHECK(Heap::ConfigureHeapDefault());
   CHECK(MemoryAllocator::Setup(Heap::MaxCapacity()));
 
   OldSpace* s = new OldSpace(Heap::OldGenerationSize(),
                              OLD_POINTER_SPACE,
@@ skipping 55 matching lines @@
   CHECK(!lo->IsEmpty());
 
   obj = lo->AllocateRaw(lo_size);
   CHECK(obj->IsFailure());
 
   lo->TearDown();
   delete lo;
 
   MemoryAllocator::TearDown();
 }