Issue 7618025: Send notifications on the IO thread when changes are made to the special storage policy. Listen f...

Issue 7618025: Send notifications on the IO thread when changes are made to the special storage policy. Listen f... (Closed)

Created:
9 years, 4 months ago by michaeln

Modified:
9 years, 4 months ago

Reviewers:
kinuko, Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Send notifications on the IO thread when changes are made to the special storage policy. Listen for those changes in the usage tracking system and fixup the cache to accurately reflect how much usage should be characterised as "unlimited" usage. TEST=modified quota_manager_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96858

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -29 lines)			Patch
M	chrome/browser/extensions/extension_special_storage_policy.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_special_storage_policy.cc	View		3 chunks	+42 lines, -18 lines	0 comments	Download
M	webkit/quota/mock_special_storage_policy.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/quota/quota_manager_unittest.cc	View	1 2 3 4	2 chunks	+32 lines, -0 lines	0 comments	Download
M	webkit/quota/special_storage_policy.h	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	webkit/quota/special_storage_policy.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	webkit/quota/usage_tracker.h	View	1 2 3 4	4 chunks	+8 lines, -5 lines	0 comments	Download
M	webkit/quota/usage_tracker.cc	View	1 2 3 4	6 chunks	+32 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

michaeln

hi... matt ptal and the extention stuff, and kinuko at the quota stuff

9 years, 4 months ago (2011-08-12 23:30:07 UTC) #1

michaeln

I went ahead and did the remaining piece of work mentioned before.

9 years, 4 months ago (2011-08-13 00:25:49 UTC) #2

kinuko

lgtm for quota part. (will we have a test for this change?) http://codereview.chromium.org/7618025/diff/3009/webkit/quota/usage_tracker.cc File webkit/quota/usage_tracker.cc ...

9 years, 4 months ago (2011-08-15 11:26:44 UTC) #3

michaeln

9 years, 4 months ago (2011-08-15 19:21:52 UTC) #5

> (will we have a test for this change?)

Updated the existing test for unlimited storage tracking.

http://codereview.chromium.org/7618025/diff/3009/webkit/quota/usage_tracker.cc
File webkit/quota/usage_tracker.cc (right):

http://codereview.chromium.org/7618025/diff/3009/webkit/quota/usage_tracker.c...
webkit/quota/usage_tracker.cc:484: global_unlimited_usage_is_valid_ = false;
On 2011/08/15 11:26:45, kinuko wrote:
> just to make it clear that this is called on the same thread can we make
> ClientUsageTracker derive from NonThreadSafe and have a thread check here?

Done.

Expand Messages | Collapse Messages