Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy.cc

Issue 7618025: Send notifications on the IO thread when changes are made to the special storage policy. Listen f... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy.cc
===================================================================
--- chrome/browser/extensions/extension_special_storage_policy.cc (revision 96595)
+++ chrome/browser/extensions/extension_special_storage_policy.cc (working copy)
@@ -7,6 +7,7 @@
#include "base/logging.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/url_constants.h"
+#include "content/browser/browser_thread.h"
ExtensionSpecialStoragePolicy::ExtensionSpecialStoragePolicy() {}
@@ -40,13 +41,18 @@
ExtensionAPIPermission::kFileBrowserHandler)) {
return;
}
- base::AutoLock locker(lock_);
- if (extension->is_hosted_app())
- protected_apps_.Add(extension);
- if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
- unlimited_extensions_.Add(extension);
- if (extension->HasAPIPermission(ExtensionAPIPermission::kFileBrowserHandler))
- file_handler_extensions_.Add(extension);
+ {
+ base::AutoLock locker(lock_);
+ if (extension->is_hosted_app())
+ protected_apps_.Add(extension);
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
+ unlimited_extensions_.Add(extension);
+ if (extension->HasAPIPermission(
+ ExtensionAPIPermission::kFileBrowserHandler)) {
+ file_handler_extensions_.Add(extension);
+ }
+ }
+ NotifyChanged();
}
void ExtensionSpecialStoragePolicy::RevokeRightsForExtension(
@@ -59,22 +65,40 @@
ExtensionAPIPermission::kFileBrowserHandler)) {
return;
}
- base::AutoLock locker(lock_);
- if (extension->is_hosted_app())
- protected_apps_.Remove(extension);
- if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
- unlimited_extensions_.Remove(extension);
- if (extension->HasAPIPermission(ExtensionAPIPermission::kFileBrowserHandler))
- file_handler_extensions_.Remove(extension);
+ {
+ base::AutoLock locker(lock_);
+ if (extension->is_hosted_app())
+ protected_apps_.Remove(extension);
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
+ unlimited_extensions_.Remove(extension);
+ if (extension->HasAPIPermission(
+ ExtensionAPIPermission::kFileBrowserHandler)) {
+ file_handler_extensions_.Remove(extension);
+ }
+ }
+ NotifyChanged();
}
void ExtensionSpecialStoragePolicy::RevokeRightsForAllExtensions() {
- base::AutoLock locker(lock_);
- protected_apps_.Clear();
- unlimited_extensions_.Clear();
- file_handler_extensions_.Clear();
+ {
+ base::AutoLock locker(lock_);
+ protected_apps_.Clear();
+ unlimited_extensions_.Clear();
+ file_handler_extensions_.Clear();
+ }
+ NotifyChanged();
}
+void ExtensionSpecialStoragePolicy::NotifyChanged() {
+ if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+ NewRunnableMethod(this,
+ &ExtensionSpecialStoragePolicy::NotifyChanged));
+ return;
+ }
+ SpecialStoragePolicy::NotifyObservers();
+}
+
//-----------------------------------------------------------------------------
// SpecialCollection helper class
//-----------------------------------------------------------------------------
« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy.h ('k') | webkit/quota/mock_special_storage_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698