Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: content/common/view_messages.h

Issue 7618016: Additional fixes for prerender/instant + browsing history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small changes Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 481f5b99fa07ced98633d2fbfc72cef32fc36156..a7dd54c589dfe2b7775f0038503cf7d79e01eb0b 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -744,17 +744,19 @@ IPC_STRUCT_END()
IPC_MESSAGE_CONTROL1(ViewMsg_SetNextPageID,
int32 /* next_page_id */)
-// Sets the history length of page_ids for a RenderView to
-// |length| entries, and moves the current page_id to the last
-// entry if it is valid.
-// The main use for this is prerendered pages, but Instant pages also use this.
-// For example, assume that there are 3 entries in the history when a
-// prerendered page is created. The new prerendered page will have a single
-// entry history like [7]. When it is swapped in, we need to extend the history
-// so it has a total length of 4 (3 for the previous history, 1 for the
-// prerendered page), so it looks like [-1 -1 -1 7].
-IPC_MESSAGE_ROUTED1(ViewMsg_SetHistoryLengthAndClear,
- int /* length */)
+// Sent to the RenderView when a prerendered or instant page is committed
+// to an existing tab. The existing tab has a history of
+// |merged_history_length| which precedes the current history of pages
+// in the render view. All page_id's >= minimum_page_id are appended to
Charlie Reis 2011/08/13 00:29:04 Nit: No apostrophe.
cbentzel 2011/08/13 02:19:12 Done.
+// this new history in the same order.
+//
+// For example, suppose the history of page_id's in the instant RenderView
+// looks like [4 7 8]. This instant RenderView is committed, and merged into
+// an existing tab with 3 history items, and every page with page_id >= 7
+// is preserved. The resulting page history looks like [-1 -1 -1 7 8].
+IPC_MESSAGE_ROUTED2(ViewMsg_SetHistoryLengthAndPrune,
+ int, /* history_length */
Charlie Reis 2011/08/13 00:29:04 merged_history_length
cbentzel 2011/08/13 02:19:12 Done.
+ int32 /* minimum_page_id */)
// Sends System Colors corresponding to a set of CSS color keywords
// down the pipe.

Powered by Google App Engine
This is Rietveld 408576698