Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: content/browser/tab_contents/test_tab_contents.h

Issue 7618016: Additional fixes for prerender/instant + browsing history. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small changes Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/test_tab_contents.h
diff --git a/content/browser/tab_contents/test_tab_contents.h b/content/browser/tab_contents/test_tab_contents.h
index fb7b1bc23ca3a8172e519c4b64d709e56eec3262..09b9cb19866afbff97ad52dfab7f72286b0d9531 100644
--- a/content/browser/tab_contents/test_tab_contents.h
+++ b/content/browser/tab_contents/test_tab_contents.h
@@ -42,12 +42,12 @@ class TestTabContents : public TabContents {
// Prevent interaction with views.
virtual bool CreateRenderViewForRenderManager(
- RenderViewHost* render_view_host);
- virtual void UpdateRenderViewSizeForRenderManager() {}
+ RenderViewHost* render_view_host) OVERRIDE;
+ virtual void UpdateRenderViewSizeForRenderManager() OVERRIDE {}
// Returns a clone of this TestTabContents. The returned object is also a
// TestTabContents. The caller owns the returned object.
- virtual TabContents* Clone();
+ virtual TabContents* Clone() OVERRIDE;
// Creates a pending navigation to the given URL with the default parameters
// and then commits the load with a page ID one larger than any seen. This
@@ -67,12 +67,26 @@ class TestTabContents : public TabContents {
bool transition_cross_site;
// Allow mocking of the RenderViewHostDelegate::View.
- virtual RenderViewHostDelegate::View* GetViewDelegate();
+ virtual RenderViewHostDelegate::View* GetViewDelegate() OVERRIDE;
void set_view_delegate(RenderViewHostDelegate::View* view) {
delegate_view_override_ = view;
}
+
+ void ExpectSetHistoryLengthAndPrune(const SiteInstance* site_instance,
cbentzel 2011/08/13 00:09:28 I'll need a comment for this function.
cbentzel 2011/08/13 02:19:12 Done.
+ int history_length,
+ int32 min_page_id);
+ virtual void SetHistoryLengthAndPrune(const SiteInstance* site_instance,
cbentzel 2011/08/13 00:09:28 Perhaps here as well.
cbentzel 2011/08/13 02:19:12 Done.
+ int history_length,
+ int32 min_page_id) OVERRIDE;
+
private:
RenderViewHostDelegate::View* delegate_view_override_;
+
+ // Expectations for call to SetHistoryLengthAndPrune
+ bool expect_set_history_length_and_prune_;
+ const SiteInstance* expect_set_history_length_and_prune_site_instance_;
+ int expect_set_history_length_and_prune_history_length_;
+ int32 expect_set_history_length_and_prune_min_page_id_;
};
#endif // CONTENT_BROWSER_TAB_CONTENTS_TEST_TAB_CONTENTS_H_

Powered by Google App Engine
This is Rietveld 408576698