Issue 7613001: Don't make chrome_browser depend on all of views gyp, since that builds test binaries as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7613001: Don't make chrome_browser depend on all of views gyp, since that builds test binaries as well. (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't make chrome_browser depend on all of views gyp, since that builds test binaries as well. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96258

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/chrome_browser.gypi	View	1	1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM for now, would be nice if it was cleaner (what is this desktop lib ...

9 years, 4 months ago (2011-08-10 19:52:26 UTC) #3

jam

9 years, 4 months ago (2011-08-10 19:55:59 UTC) #4

On 2011/08/10 19:52:26, Evan Martin wrote:
> LGTM for now, would be nice if it was cleaner (what is this desktop lib
anyway)

No idea. I'm not familiar with views at all, I just did this so we don't build
binaries unnecessarily.

Expand Messages | Collapse Messages