Issue 7606032: Fix memory leak in ConflictingDllsTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7606032: Fix memory leak in ConflictingDllsTest. (Closed)

Created:
9 years, 4 months ago by Finnur

Modified:
9 years, 4 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix memory leak in ConflictingDllsTest. BUG=92150 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96353

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	chrome/browser/diagnostics/recon_diagnostics.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/drmemory/suppressions.txt	View		1 chunk	+0 lines, -5 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

Thanks for the pointer, Timur. http://codereview.chromium.org/7606032/diff/1/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (left): http://codereview.chromium.org/7606032/diff/1/tools/valgrind/drmemory/suppressions.txt#oldcode881 tools/valgrind/drmemory/suppressions.txt:881: # http://crbug.com/92150 Timur: I ...

9 years, 4 months ago (2011-08-10 15:04:31 UTC) #1

Timur Iskhodzhanov

9 years, 4 months ago (2011-08-10 15:12:51 UTC) #2

LGTM, thanks!

http://codereview.chromium.org/7606032/diff/1/tools/valgrind/drmemory/suppres...
File tools/valgrind/drmemory/suppressions.txt (left):

http://codereview.chromium.org/7606032/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:881: # http://crbug.com/92150
Nice catch, thanks!
Should be 92159

On 2011/08/10 15:04:31, Finnur wrote:
> Timur: I think you may have made a copy-paste error here. I can fix it for you
> (during this checkin) if you give me the right bug number...

Expand Messages | Collapse Messages