Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 7606032: Fix memory leak in ConflictingDllsTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/drmemory/suppressions.txt » ('j') | tools/valgrind/drmemory/suppressions.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/diagnostics/recon_diagnostics.cc
===================================================================
--- chrome/browser/diagnostics/recon_diagnostics.cc (revision 96179)
+++ chrome/browser/diagnostics/recon_diagnostics.cc (working copy)
@@ -82,7 +82,7 @@
EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();
model->set_limited_mode(true);
model->ScanNow();
- ListValue* list = model->GetModuleList();
+ scoped_ptr<ListValue> list(model->GetModuleList());
if (!model->confirmed_bad_modules_detected() &&
!model->suspected_bad_modules_detected()) {
RecordSuccess(ASCIIToUTF16("No conflicting modules found"));
« no previous file with comments | « no previous file | tools/valgrind/drmemory/suppressions.txt » ('j') | tools/valgrind/drmemory/suppressions.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698