Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/common/extensions/extension_localization_peer.h

Issue 7602023: Use a monotonic clock (TimeTicks) to report network times to WebCore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use strong typing Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_localization_peer.h
diff --git a/chrome/common/extensions/extension_localization_peer.h b/chrome/common/extensions/extension_localization_peer.h
index 0a33bc9cd95794aec2ef1fef19ff71221d6de349..bcc91740b9264c4a543000d1bac34dbdf4f7df3f 100644
--- a/chrome/common/extensions/extension_localization_peer.h
+++ b/chrome/common/extensions/extension_localization_peer.h
@@ -34,17 +34,21 @@ class ExtensionLocalizationPeer
virtual bool OnReceivedRedirect(
const GURL& new_url,
const webkit_glue::ResourceResponseInfo& info,
+ const base::TimeTicks& start_time,
+ const base::TimeTicks& end_time,
bool* has_new_first_party_for_cookies,
GURL* new_first_party_for_cookies);
virtual void OnReceivedResponse(
- const webkit_glue::ResourceResponseInfo& info);
+ const webkit_glue::ResourceResponseInfo& info,
+ const base::TimeTicks& start_time,
+ const base::TimeTicks& end_time);
virtual void OnDownloadedData(int len) {}
virtual void OnReceivedData(const char* data,
int data_length,
int encoded_data_length);
virtual void OnCompletedRequest(const net::URLRequestStatus& status,
const std::string& security_info,
- const base::Time& completion_time);
+ const base::TimeTicks& completion_time);
jar (doing other things) 2011/11/19 03:42:32 Generally I like to see TimeTicks used more (it is
private:
friend class ExtensionLocalizationPeerTest;
@@ -75,6 +79,10 @@ class ExtensionLocalizationPeer
// Original request URL.
GURL request_url_;
+ // When the request started and the initial response was returned.
+ base::TimeTicks start_time_;
+ base::TimeTicks end_time_;
+
private:
DISALLOW_COPY_AND_ASSIGN(ExtensionLocalizationPeer);
};

Powered by Google App Engine
This is Rietveld 408576698