Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/common/extensions/extension_localization_peer.h

Issue 7602023: Use a monotonic clock (TimeTicks) to report network times to WebCore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use strong typing Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 16 matching lines...) Expand all
27 webkit_glue::ResourceLoaderBridge::Peer* peer, 27 webkit_glue::ResourceLoaderBridge::Peer* peer,
28 IPC::Message::Sender* message_sender, 28 IPC::Message::Sender* message_sender,
29 const std::string& mime_type, 29 const std::string& mime_type,
30 const GURL& request_url); 30 const GURL& request_url);
31 31
32 // ResourceLoaderBridge::Peer methods. 32 // ResourceLoaderBridge::Peer methods.
33 virtual void OnUploadProgress(uint64 position, uint64 size); 33 virtual void OnUploadProgress(uint64 position, uint64 size);
34 virtual bool OnReceivedRedirect( 34 virtual bool OnReceivedRedirect(
35 const GURL& new_url, 35 const GURL& new_url,
36 const webkit_glue::ResourceResponseInfo& info, 36 const webkit_glue::ResourceResponseInfo& info,
37 const base::TimeTicks& start_time,
38 const base::TimeTicks& end_time,
37 bool* has_new_first_party_for_cookies, 39 bool* has_new_first_party_for_cookies,
38 GURL* new_first_party_for_cookies); 40 GURL* new_first_party_for_cookies);
39 virtual void OnReceivedResponse( 41 virtual void OnReceivedResponse(
40 const webkit_glue::ResourceResponseInfo& info); 42 const webkit_glue::ResourceResponseInfo& info,
43 const base::TimeTicks& start_time,
44 const base::TimeTicks& end_time);
41 virtual void OnDownloadedData(int len) {} 45 virtual void OnDownloadedData(int len) {}
42 virtual void OnReceivedData(const char* data, 46 virtual void OnReceivedData(const char* data,
43 int data_length, 47 int data_length,
44 int encoded_data_length); 48 int encoded_data_length);
45 virtual void OnCompletedRequest(const net::URLRequestStatus& status, 49 virtual void OnCompletedRequest(const net::URLRequestStatus& status,
46 const std::string& security_info, 50 const std::string& security_info,
47 const base::Time& completion_time); 51 const base::TimeTicks& completion_time);
jar (doing other things) 2011/11/19 03:42:32 Generally I like to see TimeTicks used more (it is
48 52
49 private: 53 private:
50 friend class ExtensionLocalizationPeerTest; 54 friend class ExtensionLocalizationPeerTest;
51 55
52 // Use CreateExtensionLocalizationPeer to create an instance. 56 // Use CreateExtensionLocalizationPeer to create an instance.
53 ExtensionLocalizationPeer( 57 ExtensionLocalizationPeer(
54 webkit_glue::ResourceLoaderBridge::Peer* peer, 58 webkit_glue::ResourceLoaderBridge::Peer* peer,
55 IPC::Message::Sender* message_sender, 59 IPC::Message::Sender* message_sender,
56 const GURL& request_url); 60 const GURL& request_url);
57 61
(...skipping 10 matching lines...) Expand all
68 // Sends ExtensionHostMsg_GetMessageBundle message to the browser to fetch 72 // Sends ExtensionHostMsg_GetMessageBundle message to the browser to fetch
69 // message catalog. 73 // message catalog.
70 IPC::Message::Sender* message_sender_; 74 IPC::Message::Sender* message_sender_;
71 75
72 // Buffer for incoming data. We wait until OnCompletedRequest before using it. 76 // Buffer for incoming data. We wait until OnCompletedRequest before using it.
73 std::string data_; 77 std::string data_;
74 78
75 // Original request URL. 79 // Original request URL.
76 GURL request_url_; 80 GURL request_url_;
77 81
82 // When the request started and the initial response was returned.
83 base::TimeTicks start_time_;
84 base::TimeTicks end_time_;
85
78 private: 86 private:
79 DISALLOW_COPY_AND_ASSIGN(ExtensionLocalizationPeer); 87 DISALLOW_COPY_AND_ASSIGN(ExtensionLocalizationPeer);
80 }; 88 };
81 89
82 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_ 90 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_LOCALIZATION_PEER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698