Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 7599029: Grab bag of bugfixes for Lion fullscreen mode. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Remove unneeded include. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
index 30d2f598da30cabc50ebed3f3f82695b6a4122c6..817cabcd185d68c59f28e106ffd1d988f13ae828 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
@@ -398,12 +398,14 @@ BOOL ThePasteboardIsTooDamnBig() {
}
// If the escape key was pressed and no revert happened and we're in
- // fullscreen mode, make it resign key.
+ // fullscreen mode, give focus to the web contents, which may dismiss the
+ // overlay.
if (cmd == @selector(cancelOperation:)) {
BrowserWindowController* windowController =
[BrowserWindowController browserWindowControllerForView:self];
- if ([windowController inPresentationMode]) {
+ if ([windowController isFullscreen]) {
[windowController focusTabContents];
+ textChangedByKeyEvents_ = NO;
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698