Grab bag of bugfixes for Lion fullscreen mode.

chrome/browser/instant/instant_loader.cc

Index: chrome/browser/instant/instant_loader.cc
diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc
index fc348413487707e9b5b3526bbcf7ef897a991242..3f1725e60e4db66be1d8d9b2658aacc464c9ad87 100644
--- a/chrome/browser/instant/instant_loader.cc
+++ b/chrome/browser/instant/instant_loader.cc
@@ -894,7 +894,10 @@ gfx::Rect InstantLoader::GetOmniboxBoundsInTermsOfPreview() {
 
   // In the current Chrome UI, these must always be true so they sanity check
   // the above operations. In a future UI, these may be removed or adjusted.
-  DCHECK_EQ(0, intersection.y());

[sky, 2011/08/17 15:43:38]

What does y end up as in mac fullscreen mode? Do you have a screenshot of how
instant with mac fullscreen looks?

[rohitrao (ping after 24h), 2011/08/17 16:02:25]

y ends up being a positive number (greater than zero).  In normal windows, the
omnibox is positioned so that its top edge extends above the preview area.  In
fullscreen mode, the preview area covers the whole screen, but the
toolbar/tabstrip are in a floating overlay bar, so the omnibox ends up being
completely enclosed by the preview area (hence the positive y).

I'll send you a screenshot.

+  // There is no point in sanity-checking |intersection.y()| because the omnibox
+  // can be placed anywhere vertically relative to the preview (for example, in
+  // Mac fullscreen mode, the omnibox is entirely enclosed by the preview
+  // bounds).
   DCHECK_LE(0, intersection.x());
   DCHECK_LE(0, intersection.width());
   DCHECK_LE(0, intersection.height());