Grab bag of bugfixes for Lion fullscreen mode.

chrome/browser/instant/instant_loader.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_loader.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 876 matching lines @@
   gfx::Rect intersection(omnibox_bounds_.Intersect(preview_bounds));
 
   // Translate into window's coordinates.
   if (!intersection.IsEmpty()) {
     intersection.Offset(-preview_bounds.origin().x(),
                         -preview_bounds.origin().y());
   }
 
   // In the current Chrome UI, these must always be true so they sanity check
   // the above operations. In a future UI, these may be removed or adjusted.
-  DCHECK_EQ(0, intersection.y());

[sky, 2011/08/17 15:43:38]

What does y end up as in mac fullscreen mode? Do you have a screenshot of how
instant with mac fullscreen looks?

[rohitrao (ping after 24h), 2011/08/17 16:02:25]

y ends up being a positive number (greater than zero).  In normal windows, the
omnibox is positioned so that its top edge extends above the preview area.  In
fullscreen mode, the preview area covers the whole screen, but the
toolbar/tabstrip are in a floating overlay bar, so the omnibox ends up being
completely enclosed by the preview area (hence the positive y).

I'll send you a screenshot.

+  // There is no point in sanity-checking |intersection.y()| because the omnibox
+  // can be placed anywhere vertically relative to the preview (for example, in
+  // Mac fullscreen mode, the omnibox is entirely enclosed by the preview
+  // bounds).
   DCHECK_LE(0, intersection.x());
   DCHECK_LE(0, intersection.width());
   DCHECK_LE(0, intersection.height());
 
   return intersection;
 }
 
 void InstantLoader::PageDoesntSupportInstant(bool needs_reload) {
   frame_load_observer_.reset(NULL);
 
@@ skipping 117 matching lines @@
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (cl->HasSwitch(switches::kInstantURL))
     instant_url = GURL(cl->GetSwitchValueASCII(switches::kInstantURL));
   preview_contents_->controller().LoadURL(instant_url, GURL(), transition_type);
   RenderViewHost* host = preview_contents_->render_view_host();
   host->Send(new ViewMsg_SearchBoxChange(
       host->routing_id(), user_text, verbatim, 0, 0));
   frame_load_observer_.reset(new FrameLoadObserver(
       this, preview_contents()->tab_contents(), user_text, verbatim));
 }