Issue 7598013: Do not allocate depth-stencil buffers for GLSurfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7598013: Do not allocate depth-stencil buffers for GLSurfaces. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Stephen White

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Do not allocate depth-stencil buffers for GLSurfaces. We don't need them here. Whenever we need a depth-stencil buffer, it's as a renderbuffer attached to a non-default FBO. This will save some video memory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95964

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -8 lines)			Patch
M	ui/gfx/gl/gl_context_osmesa.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_egl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_glx.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_wgl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

I don't know this code that well, but I trust that you and/or the layout ...

9 years, 4 months ago (2011-08-08 22:07:20 UTC) #2

Change committed as 95964

Expand Messages | Collapse Messages