Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 7595005: Revert 95815 - Make extension file URL access opt-in. (Closed)

Created:
9 years, 4 months ago by jstritar
Modified:
9 years, 4 months ago
Reviewers:
jstritar
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 95815 - Make extension file URL access opt-in. This corrects an issue causing file URL access to default on for <all_urls> and file:/// permissions. We also revert all extension's "allow file access" flags to false since we can't distinguish between extensions that were installed with the bug present and those where the user clicked allow file access. Unpacked extensions will now have opt-in file access as well. BUG=91577 TEST=ExtensionServiceTest.DefaultFileAccess Review URL: http://codereview.chromium.org/7574017 TBR=jstritar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/good/Preferences View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/permissions/files/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jstritar
9 years, 4 months ago (2011-08-08 16:06:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698