Make extension file URL access opt-in.

Make extension file URL access opt-in.

This corrects an issue causing file URL access to default on for <all_urls> and file:/// permissions. We also revert all extension's "allow file access" flags to false since we can't distinguish between extensions that were installed with the bug present and those where the user clicked allow file access.

BUG=91577
TEST=ExtensionServiceTest.DefaultFileAccess

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96041

[asargent_no_longer_on_chrome, 2011-08-04 21:56:02]

LGTM

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.cc (left):

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.cc:2212:
extension_prefs_->SetAllowFileAccess(id, true);
Ah, I guess this is the actual location of the bug.

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service_unittest.cc:1759: // Tests that file
access if OFF by default.
typo: "access if OFF" -> "access is OFF"

[jstritar, 2011-08-05 15:13:28]

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.cc (left):

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.cc:2212:
extension_prefs_->SetAllowFileAccess(id, true);
On 2011/08/04 21:56:03, Antony Sargent wrote:
> Ah, I guess this is the actual location of the bug.

Yep. The ShouldAlwaysAllowFileAccess method seemed error prone so I just decided
to get rid of it and make all extension types default to no file access.

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7574017/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service_unittest.cc:1759: // Tests that file
access if OFF by default.
On 2011/08/04 21:56:03, Antony Sargent wrote:
> typo: "access if OFF" -> "access is OFF"

Done.

[jstritar, 2011-08-08 21:55:12]

I landed this today but reverted after realizing a subtle issue. Extensions are
configured with file access by passing a flag in while loading the manifest (the
flag is used to set the valid schemes of the match patterns). We initialize the
flag from the extension preferences. For LOAD extensions, we lookup the
preference for the ID generated from the extension's path, but the extension's
ID changes once loaded if there's a key in the manifest. After loading, this new
ID is used everywhere including when the UI updates the allow file access
setting.

I'm working on a fix, but it's kind of ugly so far. 

Maybe we should just keep file access defaulting on for LOAD extensions?

[jstritar, 2011-08-09 13:53:39]

I backed out the changes to how unpacked extensions work so this only fixes the
location issue. I think that's easier for now given how the IDs change. Do you
want to take a quick look, Antony?

[asargent_no_longer_on_chrome, 2011-08-09 18:11:23]

On 2011/08/09 13:53:39, jstritar wrote:
> I backed out the changes to how unpacked extensions work so this only fixes
the
> location issue. I think that's easier for now given how the IDs change. Do you
> want to take a quick look, Antony?
LGTM again.

[commit-bot: I haz the power, 2011-08-09 19:49:20]

Change committed as 96041