Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: media/base/media_log.cc

Issue 7591001: Log BufferedResourceLoader events to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Picking nits. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/base/media_log_event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index af4e75bbd89964dfbca3de8782513744fbe4ec3d..38be1269b1b81bb83da062348afd9b149d0f1d80 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -26,6 +26,8 @@ const char* MediaLog::EventTypeToString(MediaLogEvent::Type type) {
return "PLAY";
case MediaLogEvent::PAUSE:
return "PAUSE";
+ case MediaLogEvent::BUFFERED_EXTENTS_CHANGED:
+ return "BUFFERED_EXTENTS_CHANGED";
}
NOTREACHED();
return NULL;
@@ -37,27 +39,32 @@ MediaLog::MediaLog() {
MediaLog::~MediaLog() {}
-void MediaLog::Load(const std::string& url) {
- MediaLogEvent* event = CreateEvent(MediaLogEvent::LOAD);
- event->params.SetString("url", url);
- AddEvent(event);
-}
-
-void MediaLog::AddEventOfType(MediaLogEvent::Type type) {
- MediaLogEvent* event = CreateEvent(type);
- AddEvent(event);
+void MediaLog::AddEvent(MediaLogEvent* event) {
+ scoped_ptr<MediaLogEvent> e(event);
}
MediaLogEvent* MediaLog::CreateEvent(MediaLogEvent::Type type) {
- MediaLogEvent* event = new MediaLogEvent;
+ scoped_ptr<MediaLogEvent> event(new MediaLogEvent);
event->id = id_;
event->type = type;
event->time = base::Time::Now();
- return event;
+ return event.release();
}
-void MediaLog::AddEvent(MediaLogEvent* event) {
- scoped_ptr<MediaLogEvent> e(event);
+MediaLogEvent* MediaLog::CreateLoadEvent(const std::string& url) {
+ scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::LOAD));
+ event->params.SetString("url", url);
+ return event.release();
+}
+
+MediaLogEvent* MediaLog::CreateBufferedExtentsChangedEvent(
+ size_t start, size_t current, size_t end) {
+ scoped_ptr<MediaLogEvent> event(
+ CreateEvent(MediaLogEvent::BUFFERED_EXTENTS_CHANGED));
+ event->params.SetInteger("buffer_start", start);
+ event->params.SetInteger("buffer_current", current);
+ event->params.SetInteger("buffer_end", end);
+ return event.release();
}
} //namespace media
« no previous file with comments | « media/base/media_log.h ('k') | media/base/media_log_event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698