Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: media/base/media_log.h

Issue 7591001: Log BufferedResourceLoader events to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Picking nits. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index fcf0c31714540ebd7cb5f360ce7d80add4a27703..88417acf41136fc909a7e44d6a05190d440dd9c1 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -13,26 +13,21 @@ namespace media {
class MediaLog : public base::RefCountedThreadSafe<MediaLog> {
public:
-
// Return a string to represent an EventType.
static const char* EventTypeToString(MediaLogEvent::Type type);
MediaLog();
- // Methods called by loggers when events occur. These generate appropriate
- // event parameters so the caller need not worry about them.
- void Load(const std::string& url);
-
// Add an event to this log. Overriden by inheritors to actually do something
// with it.
// Takes ownership of |event|.
virtual void AddEvent(MediaLogEvent* event);
- // Convenience method for adding an event with no parameters.
- void AddEventOfType(MediaLogEvent::Type type);
-
- // Convenience method for filling in common fields of a new event.
+ // Helper methods to create events and their parameters.
MediaLogEvent* CreateEvent(MediaLogEvent::Type type);
+ MediaLogEvent* CreateLoadEvent(const std::string& url);
+ MediaLogEvent* CreateBufferedExtentsChangedEvent(size_t start, size_t current,
+ size_t end);
protected:
friend class base::RefCountedThreadSafe<MediaLog>;
« no previous file with comments | « no previous file | media/base/media_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698