Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webkit/glue/media/buffered_data_source_unittest.cc

Issue 7591001: Log BufferedResourceLoader events to MediaLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Responding to feedback, updating tests. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/media/buffered_data_source_unittest.cc
diff --git a/webkit/glue/media/buffered_data_source_unittest.cc b/webkit/glue/media/buffered_data_source_unittest.cc
index 5cdde517dc9a40eab5f0f75dd4368a882b6dce96..1a77a8c9a6461ec5fdae06adb16a8c3e92332c9d 100644
--- a/webkit/glue/media/buffered_data_source_unittest.cc
+++ b/webkit/glue/media/buffered_data_source_unittest.cc
@@ -5,6 +5,7 @@
#include <algorithm>
#include "base/test/test_timeouts.h"
+#include "media/base/media_log.h"
#include "media/base/mock_callback.h"
#include "media/base/mock_filter_host.h"
#include "media/base/mock_filters.h"
@@ -50,7 +51,7 @@ enum NetworkState {
class MockBufferedDataSource : public BufferedDataSource {
public:
MockBufferedDataSource(MessageLoop* message_loop, WebFrame* frame)
- : BufferedDataSource(message_loop, frame) {
+ : BufferedDataSource(message_loop, frame, new media::MediaLog()) {
}
virtual base::TimeDelta GetTimeoutMilliseconds() {
@@ -68,7 +69,8 @@ class MockBufferedDataSource : public BufferedDataSource {
class MockBufferedResourceLoader : public BufferedResourceLoader {
public:
- MockBufferedResourceLoader() : BufferedResourceLoader(GURL(), 0, 0) {
+ MockBufferedResourceLoader() : BufferedResourceLoader(GURL(), 0, 0,
scherkus (not reviewing) 2011/08/09 00:59:40 in this case I'd just drop the : bit to next line
Scott Franklin 2011/08/09 01:16:08 Done.
+ new media::MediaLog()) {
}
MOCK_METHOD3(Start, void(net::CompletionCallback* read_callback,

Powered by Google App Engine
This is Rietveld 408576698