Chromium Code Reviews| Index: media/base/media_log.h |
| diff --git a/media/base/media_log.h b/media/base/media_log.h |
| index fcf0c31714540ebd7cb5f360ce7d80add4a27703..7afa4978844bafb9ffd8c783bc5c28add1f0826a 100644 |
| --- a/media/base/media_log.h |
| +++ b/media/base/media_log.h |
| @@ -19,18 +19,16 @@ class MediaLog : public base::RefCountedThreadSafe<MediaLog> { |
| MediaLog(); |
| - // Methods called by loggers when events occur. These generate appropriate |
| - // event parameters so the caller need not worry about them. |
| - void Load(const std::string& url); |
| + // Helper methods to create specific types of events with their parameters. |
| + MediaLogEvent* CreateLoadEvent(const std::string& url); |
| + MediaLogEvent* CreateBufferedExtentsChangedEvent(size_t start, size_t current, |
|
scherkus (not reviewing)
2011/08/09 00:59:40
nit: move these down to CreateEvent() + update .cc
Scott Franklin
2011/08/09 01:16:08
Done.
|
| + size_t end); |
| // Add an event to this log. Overriden by inheritors to actually do something |
| // with it. |
| // Takes ownership of |event|. |
| virtual void AddEvent(MediaLogEvent* event); |
| - // Convenience method for adding an event with no parameters. |
| - void AddEventOfType(MediaLogEvent::Type type); |
| - |
| // Convenience method for filling in common fields of a new event. |
| MediaLogEvent* CreateEvent(MediaLogEvent::Type type); |