Remove mock_ffmpeg and update media unittests.

media/base/media.h

Index: media/base/media.h
diff --git a/media/base/media.h b/media/base/media.h
index 6bbad4cbbb9ec9caa484c50c240091c41e1de712..1b4123d9069f2242afcf459c72b864f89bd42d1b 100644
--- a/media/base/media.h
+++ b/media/base/media.h
@@ -25,6 +25,9 @@ namespace media {
 // Returns true if everything was successfully initialized, false otherwise.
 bool InitializeMediaLibrary(const FilePath& module_dir);
 
+// Helper method for unit tests to avoid boiler plate code everywhere.
+bool InitializeMediaLibraryForTesting();

[scherkus (not reviewing), 2011/08/11 01:26:29]

It looks like this gets called in many places.

Would it make sense to perhaps make a single call / inline the call inside of
media/base/run_all_unittests.cc itself?

Perhaps with a CHECK() and useful diagnostic error message

it's also worth noting we need to be careful that ffmpeg doesn't retain any
state between tests -- does re-loading the library take care of that?

There's a few options here we can consider:
  1) Extending base::TestSuite() to have custom Initialize/Shutdown() impls
  2) Extending testing::Test to have a testing::FFmpegTest that calls
InitializeMediaLibraryForTesting()
  3) Use ::testing::Environment:
http://code.google.com/p/googletest/wiki/AdvancedGuide#Global_Set-Up_and_Tear...
  4) ???

[acolwell GONE FROM CHROMIUM, 2011/08/11 23:54:40]

Done.
This is tricky because ffmpeg doesn't provide ways to unregister protocol
handlers and filters. Unloading and reloading might help a little bit. Aside
from registering the URL handler and the test filter, I don't believe FFmpeg
retains any other state between tests.

+
 // Use this if you need to check whether the media library is initialized
 // for the this process, without actually trying to initialize it.
 bool IsMediaLibraryInitialized();