Remove mock_ffmpeg and update media unittests.

media/base/media.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Contains code that should be used for initializing, or querying the state
 // of the media library as a whole.
 
 #ifndef MEDIA_BASE_MEDIA_H_
 #define MEDIA_BASE_MEDIA_H_
 
 class FilePath;
 
 namespace media {
 
 // Attempts to initialize the media library (loading DLLs, DSOs, etc.).
 //
 // If |module_dir| is the emptry string, then the system default library paths
 // are searched for the dynamic libraries.  If a |module_dir| is provided, then
 // only the specified |module_dir| will be searched for the dynamic libraries.
 //
 // If multiple initializations are attempted with different |module_dir|s
 // specified then the first one to succeed remains effective for the lifetime
 // of the process.
 //
 // Returns true if everything was successfully initialized, false otherwise.
 bool InitializeMediaLibrary(const FilePath& module_dir);
 
+// Helper method for unit tests to avoid boiler plate code everywhere.
+bool InitializeMediaLibraryForTesting();

[scherkus (not reviewing), 2011/08/11 01:26:29]

It looks like this gets called in many places.

Would it make sense to perhaps make a single call / inline the call inside of
media/base/run_all_unittests.cc itself?

Perhaps with a CHECK() and useful diagnostic error message

it's also worth noting we need to be careful that ffmpeg doesn't retain any
state between tests -- does re-loading the library take care of that?

There's a few options here we can consider:
  1) Extending base::TestSuite() to have custom Initialize/Shutdown() impls
  2) Extending testing::Test to have a testing::FFmpegTest that calls
InitializeMediaLibraryForTesting()
  3) Use ::testing::Environment:
http://code.google.com/p/googletest/wiki/AdvancedGuide#Global_Set-Up_and_Tear...
  4) ???

[acolwell GONE FROM CHROMIUM, 2011/08/11 23:54:40]

Done.
This is tricky because ffmpeg doesn't provide ways to unregister protocol
handlers and filters. Unloading and reloading might help a little bit. Aside
from registering the URL handler and the test filter, I don't believe FFmpeg
retains any other state between tests.

+
 // Use this if you need to check whether the media library is initialized
 // for the this process, without actually trying to initialize it.
 bool IsMediaLibraryInitialized();
 
 // Attempts to initialize OpenMAX library.
 //
 // Returns true if OpenMAX was successfully initialized and loaded.
 bool InitializeOpenMaxLibrary(const FilePath& module_dir);
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MEDIA_H_