Add functionality to OriginBoundCertStore interface and implementations.

net/base/origin_bound_cert_store.h

Index: net/base/origin_bound_cert_store.h
===================================================================
--- net/base/origin_bound_cert_store.h	(revision 94628)
+++ net/base/origin_bound_cert_store.h	(working copy)
@@ -21,6 +21,12 @@
 
 class NET_API OriginBoundCertStore {
  public:
+  struct OriginBoundCertInfo {
+    std::string origin;
+    std::string private_key;
+    std::string cert;
+  };

[rkn, 2011/08/09 20:58:24]

The need for this struct suggests that we ought to un-nest the
DefaultOriginBoundCertStore::OriginBoundCert class. I intend to do this in a
subsequent CL.

[wtc, 2011/08/10 21:35:59]

Please document this struct.

+
   virtual ~OriginBoundCertStore() {}
 
   // TODO(rkn): Specify certificate type (RSA or DSA).
@@ -39,6 +45,16 @@
                                   const std::string& private_key,
                                   const std::string& cert) = 0;

[wtc, 2011/08/10 21:35:59]

Add "and the corresponding private key" to the comments for these methods.

The input arguments to this function are exactly the members
of the OriginBoundCertInfo structure, so this function can
also just take a const OriginBoundCertInfo& input argument.
But I'm not sure if that's a good idea.

 
+  // Removes an origin bound cert from the store.

[wtc, 2011/08/10 21:35:59]

The new methods probably should all return a success/failure
status.

+  virtual void DeleteOriginBoundCert(const std::string& origin) = 0;
+
+  // Removes all origin bound certs from the store.
+  virtual void DeleteAll() = 0;
+
+  // Returns all origin bound certs.
+  virtual void GetAllOriginBoundCerts(
+      std::vector<OriginBoundCertInfo>* origin_bound_certs) = 0;
+
   // Returns the number of certs in the store.
   // Public only for unit testing.
   virtual int GetCertCount() = 0;