Add functionality to OriginBoundCertStore interface and implementations.

net/base/origin_bound_cert_store.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_ORIGIN_BOUND_CERT_STORE_H_
 #define NET_BASE_ORIGIN_BOUND_CERT_STORE_H_
 #pragma once
 
 #include <string>

[wtc, 2011/08/10 21:35:59]

We should include <vector>.

 
 #include "net/base/net_api.h"
 
 namespace net {
 
 // An interface for storing and retrieving origin bound certs. Origin bound
 // certificates are specified in
 // http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-00.html.
 
 // Owned only by a single OriginBoundCertService object, which is responsible
 // for deleting it.
 
 class NET_API OriginBoundCertStore {
  public:
+  struct OriginBoundCertInfo {
+    std::string origin;
+    std::string private_key;
+    std::string cert;
+  };

[rkn, 2011/08/09 20:58:24]

The need for this struct suggests that we ought to un-nest the
DefaultOriginBoundCertStore::OriginBoundCert class. I intend to do this in a
subsequent CL.

[wtc, 2011/08/10 21:35:59]

Please document this struct.

+
   virtual ~OriginBoundCertStore() {}
 
   // TODO(rkn): Specify certificate type (RSA or DSA).
   // TODO(rkn): File I/O may be required, so this should have an asynchronous
   // interface.
   // Returns true on success. |private_key_result| stores a DER-encoded
   // PrivateKeyInfo struct and |cert_result| stores a DER-encoded
   // certificate. Returns false if no origin bound cert exists for the
   // specified origin.
   virtual bool GetOriginBoundCert(const std::string& origin,
                                   std::string* private_key_result,
                                   std::string* cert_result) = 0;
 
   // Adds an origin bound cert to the store.
   virtual bool SetOriginBoundCert(const std::string& origin,
                                   const std::string& private_key,
                                   const std::string& cert) = 0;

[wtc, 2011/08/10 21:35:59]

Add "and the corresponding private key" to the comments for these methods.

The input arguments to this function are exactly the members
of the OriginBoundCertInfo structure, so this function can
also just take a const OriginBoundCertInfo& input argument.
But I'm not sure if that's a good idea.

 
+  // Removes an origin bound cert from the store.

[wtc, 2011/08/10 21:35:59]

The new methods probably should all return a success/failure
status.

+  virtual void DeleteOriginBoundCert(const std::string& origin) = 0;
+
+  // Removes all origin bound certs from the store.
+  virtual void DeleteAll() = 0;
+
+  // Returns all origin bound certs.
+  virtual void GetAllOriginBoundCerts(
+      std::vector<OriginBoundCertInfo>* origin_bound_certs) = 0;
+
   // Returns the number of certs in the store.
   // Public only for unit testing.
   virtual int GetCertCount() = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_ORIGIN_BOUND_CERT_STORE_H_