Reland 95309. Add a template to handle properly issuing completion callbacks.

Reland 95309. Add a template to handle properly issuing completion callbacks.
This fixes some bugs where we forgot to issue completion callbacks in some
error cases in the proxy, and cleans up the cases that were already doing this
properly.

This removes the PPB_AudioTrusted_API and folds those functions into the
regular Audio API. I'm trying to merge more things to have a smaller explosion
of APIs and the boilerplate associated with them.
Original review URL: http://codereview.chromium.org/7551032
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95859

[brettw, 2011-08-06 18:39:51]

This is the same as the previous patch, but setting the flag in the SetResult
function so it doesn't DCHECK.

[cpu_(ooo_6.6-7.5), 2011-08-08 18:00:19]

So you are saying that the difference is

+  void SetResult(int32_t result) {
+    DCHECK(needs_running_)
+    needs_running_ = false;   <----- here?
+    if (result != PP_OK_COMPLETIONPENDING)
+      callback_.Run(result);
+  }

[brettw, 2011-08-08 19:00:22]

On Mon, Aug 8, 2011 at 11:00 AM,  <cpu@chromium.org> wrote:
> So you are saying that the difference is
>
> +  void SetResult(int32_t result) {
> +    DCHECK(needs_running_)
> +    needs_running_ = false;   <----- here?
> +    if (result != PP_OK_COMPLETIONPENDING)
> +      callback_.Run(result);
> +  }

Correct, sorry, I meant to upload the original patch so you could see the diff.

Brett

[cpu_(ooo_6.6-7.5), 2011-08-08 19:39:42]

lgtm