Issue 7551032: Add a template to handle properly issuing completion callbacks. This fixes

Issue 7551032: Add a template to handle properly issuing completion callbacks. This fixes (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a template to handle properly issuing completion callbacks. This fixes some bugs where we forgot to issue completion callbacks in some error cases in the proxy, and cleans up the cases that were already doing this properly. This removes the PPB_AudioTrusted_API and folds those functions into the regular Audio API. I'm trying to merge more things to have a smaller explosion of APIs and the boilerplate associated with them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95309

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -159 lines)			Patch
M	ppapi/ppapi_shared.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/enter_proxy.h	View	1 2	2 chunks	+90 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 2	8 chunks	+48 lines, -22 lines	0 comments	Download
M	ppapi/proxy/ppb_broker_proxy.cc	View		5 chunks	+10 lines, -12 lines	0 comments	Download
M	ppapi/proxy/ppb_file_chooser_proxy.cc	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	ppapi/proxy/ppb_file_system_proxy.cc	View		1 chunk	+4 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_menu_proxy.cc	View		1 chunk	+5 lines, -13 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_2d_proxy.cc	View		1 chunk	+5 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View		1 chunk	+3 lines, -11 lines	0 comments	Download
M	ppapi/proxy/ppb_surface_3d_proxy.cc	View		1 chunk	+3 lines, -11 lines	0 comments	Download
M	ppapi/proxy/ppb_url_loader_proxy.cc	View		1 chunk	+4 lines, -13 lines	0 comments	Download
M	ppapi/thunk/ppb_audio_api.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_audio_thunk.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
D	ppapi/thunk/ppb_audio_trusted_api.h	View		1 chunk	+0 lines, -27 lines	0 comments	Download
M	ppapi/thunk/ppb_audio_trusted_thunk.cc	View		5 chunks	+7 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_impl.h	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_impl.cc	View		4 chunks	+8 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm btw, the rejiggering of the thingamajig, err audio just got a cursory pass because ...

9 years, 4 months ago (2011-08-03 00:57:21 UTC) #2

brettw

9 years, 4 months ago (2011-08-03 17:36:29 UTC) #3

http://codereview.chromium.org/7551032/diff/9001/ppapi/proxy/enter_proxy.h
File ppapi/proxy/enter_proxy.h (right):

http://codereview.chromium.org/7551032/diff/9001/ppapi/proxy/enter_proxy.h#ne...
ppapi/proxy/enter_proxy.h:108: A a)
Good point, this should be const& to match the CompletionCallbackFactory.

http://codereview.chromium.org/7551032/diff/9001/ppapi/proxy/ppb_broker_proxy.cc
File ppapi/proxy/ppb_broker_proxy.cc (right):

http://codereview.chromium.org/7551032/diff/9001/ppapi/proxy/ppb_broker_proxy...
ppapi/proxy/ppb_broker_proxy.cc:17: using ppapi::thunk::PPB_Broker_API;
I'm not sure what you're saying here, I did the using thing in the audio file as
well.

Expand Messages | Collapse Messages